Refactor/clean create astro logs (#3212)

* refactor: simplify dir error log to avoid wrapped text

* refactor: remove redundant "issue" callout

* chore: changeset

* chore: update tests for new dir log
This commit is contained in:
Ben Holmes 2022-04-26 20:38:31 -04:00 committed by GitHub
parent 8f2f4de5dc
commit 00fc1326ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 8 deletions

View file

@ -0,0 +1,5 @@
---
'create-astro': patch
---
Simplify logging during welcome message and directory selection

View file

@ -45,11 +45,6 @@ export async function main() {
logger.debug('Verbose logging turned on');
console.log(`\n${bold('Welcome to Astro!')} ${gray(`(create-astro v${version})`)}`);
console.log(
`If you encounter a problem, visit ${cyan(
'https://github.com/withastro/astro/issues'
)} to search or file a new issue.\n`
);
let spinner = ora({ color: 'green', text: 'Prepare for liftoff.' });
@ -66,8 +61,7 @@ export async function main() {
}
if (!cwd || !isEmpty(cwd)) {
const notEmptyMsg = (dirPath: string) =>
`"${bold(dirPath)}" is not empty. Please clear contents or choose a different path.`;
const notEmptyMsg = (dirPath: string) => `"${bold(dirPath)}" is not empty!`;
if (!isEmpty(cwd)) {
let rejectProjectDir = ora({ color: 'red', text: notEmptyMsg(cwd) });

View file

@ -58,7 +58,7 @@ describe('[create-astro] select directory', function () {
return promiseWithTimeout((resolve) => {
const { stdout, stdin } = setup();
stdout.on('data', (chunk) => {
if (chunk.includes('Please clear contents or choose a different path.')) {
if (chunk.includes('is not empty!')) {
resolve();
}
if (chunk.includes(PROMPT_MESSAGES.directory)) {