esbuild respects vite.build.minify option (#6222)

* esbuild respects `vite.build.minify` option
* Docs update
---------
Co-authored-by: AirBorne04 <>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
This commit is contained in:
Daniel 2023-04-27 10:11:05 +02:00 committed by GitHub
parent ec5f6a07ae
commit 081b2402cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 25 additions and 2 deletions

View file

@ -0,0 +1,5 @@
---
'@astrojs/cloudflare': patch
---
add option to compile unminified code

View file

@ -108,10 +108,28 @@ By default, `@astrojs/cloudflare` will generate a `_routes.json` file that lists
## Troubleshooting ## Troubleshooting
For help, check out the `#support` channel on [Discord](https://astro.build/chat). Our friendly Support Squad members are here to help! For help, check out the `#support` channel on [Discord](https://astro.build/chat). Our friendly Support Squad members are here to help!
You can also check our [Astro Integration Documentation][astro-integration] for more on integrations. You can also check our [Astro Integration Documentation][astro-integration] for more on integrations.
### Meaningful error messages
Currently, errors during running your application in Wrangler are not very useful, due to the minification of your code. For better debugging, you can add `vite.build.minify = false` setting to your `astro.config.js`
```
export default defineConfig({
adapter: cloudflare(),
output: 'server',
vite: {
build: {
minify: false
}
}
});
```
## Contributing ## Contributing
This package is maintained by Astro's Core team. You're welcome to submit an issue or PR! This package is maintained by Astro's Core team. You're welcome to submit an issue or PR!

View file

@ -95,7 +95,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
// A URL for the final build path after renaming // A URL for the final build path after renaming
const finalBuildUrl = pathToFileURL(buildPath.replace(/\.mjs$/, '.js')); const finalBuildUrl = pathToFileURL(buildPath.replace(/\.mjs$/, '.js'));
await esbuild.build({ await esbuild.build({
target: 'es2020', target: 'es2020',
platform: 'browser', platform: 'browser',
entryPoints: [entryPath], entryPoints: [entryPath],
@ -103,7 +103,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
allowOverwrite: true, allowOverwrite: true,
format: 'esm', format: 'esm',
bundle: true, bundle: true,
minify: true, minify: _config.vite?.build?.minify !== false,
banner: { banner: {
js: SHIM, js: SHIM,
}, },