michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Update the Astro.cookies.set types to receive boolean and numbers (#5047)

Browse source
This commit is contained in:
Matthew Phillips 2022-10-12 08:31:55 -04:00 committed by GitHub
parent baf88ee9e5
commit 1e27992437
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 53 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.changeset/witty-sheep-wave.md Normal file
View file

@ -0,0 +1,7 @@
---
'astro': patch
---
Update Astro.cookies.set types to allow booleans and numbers
Note that booleans and numbers were already allowed, they just were not allowed by the type definitions.

2
packages/astro/src/core/cookies/cookies.ts
View file

@ -25,7 +25,7 @@ interface AstroCookieInterface {
interface AstroCookiesInterface { interface AstroCookiesInterface {
get(key: string): AstroCookieInterface; get(key: string): AstroCookieInterface;
has(key: string): boolean; has(key: string): boolean;
set(key: string, value: string | Record<string, any>, options?: AstroCookieSetOptions): void; set(key: string, value: string | number | boolean | Record<string, any>, options?: AstroCookieSetOptions): void;
delete(key: string, options?: AstroCookieDeleteOptions): void; delete(key: string, options?: AstroCookieDeleteOptions): void;
} }

10
packages/astro/test/units/cookies/set.test.js
View file

@ -45,6 +45,16 @@ describe('astro/src/core/cookies', () => {
expect(headers[0]).to.equal('one=2'); expect(headers[0]).to.equal('one=2');
}); });
it('Can pass a boolean', () => {
let req = new Request('http://example.com/');
let cookies = new AstroCookies(req);
cookies.set('admin', true);
expect(cookies.get('admin').boolean()).to.equal(true);
let headers = Array.from(cookies.headers());
expect(headers).to.have.a.lengthOf(1);
expect(headers[0]).to.equal('admin=true');
});
it('Can get the value after setting', () => { it('Can get the value after setting', () => {
let req = new Request('http://example.com/'); let req = new Request('http://example.com/');
let cookies = new AstroCookies(req); let cookies = new AstroCookies(req);

17
packages/integrations/deno/test/basics.test.ts
View file

@ -126,3 +126,20 @@ Deno.test({
sanitizeResources: false, sanitizeResources: false,
sanitizeOps: false, sanitizeOps: false,
}); });
Deno.test({
name: 'Astro.cookies',
permissions: defaultTestPermissions,
async fn() {
await startApp(async (baseUrl: URL) => {
const url = new URL('/admin', baseUrl);
const resp = await fetch(url, { redirect: 'manual' });
assertEquals(resp.status, 302);
const headers = resp.headers;
assertEquals(headers.get('set-cookie'), 'logged-in=false; Max-Age=77760000; Path=/');
});
},
sanitizeResources: false,
sanitizeOps: false,
});

8
packages/integrations/deno/test/fixtures/basics/src/pages/admin.astro vendored Normal file
View file

@ -0,0 +1,8 @@
---
Astro.cookies.set('logged-in', false, {
maxAge: 60 * 60 * 24 * 900,
path: '/'
});
return Astro.redirect('/login');
---

10
packages/integrations/deno/test/fixtures/basics/src/pages/login.astro vendored Normal file
View file

@ -0,0 +1,10 @@
---
---
<html>
<head>
<title>Testing</title>
</head>
<body>
<h1>Testing</h1>
</body>
</html>