michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

adjusting cloudflare adapter and solid ssr to work together (#4888)

Browse source 
* adjusting cloudflare adapter (respecting user config)
define better solid ssr config

* only inline the framework

this needs to happen for worker build in order to have the correct build mode for the framework, which needs the nodejs no matter if it is for node or the browser.

Co-authored-by: AirBorne04 <daniel@floatingpixels.com>
This commit is contained in:
Daniel 2022-10-06 16:28:47 +02:00 committed by GitHub
parent e5b526c3a5
commit 2dc582ac5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.changeset/cuddly-clouds-complain.md Normal file
View file

@ -0,0 +1,7 @@
---
'@astrojs/cloudflare': major
'@astrojs/solid-js': patch
---
adjusting the build settings for cloudflare (reverting back to platform browser over neutral)
adjusting the ssr settings for solidjs (to build for node)

11
packages/integrations/cloudflare/src/index.ts
View file

@ -65,11 +65,8 @@ export default function createIntegration(args?: Options): AstroIntegration {
(vite.resolve.alias as Record<string, string>)[alias.find] = alias.replacement;
}
}
vite.ssr = {
...vite.ssr,
target: 'webworker',
};
vite.ssr = vite.ssr || {};
vite.ssr.target = vite.ssr.target || 'webworker';
}
},
'astro:build:done': async () => {
@ -77,9 +74,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
const pkg = fileURLToPath(entryUrl);
await esbuild.build({
target: 'es2020',
platform: 'neutral',
mainFields: ['main', 'module'],
conditions: ['worker', 'node'],
platform: 'browser',
entryPoints: [pkg],
outfile: pkg,
allowOverwrite: true,

2
packages/integrations/solid/src/index.ts
View file

@ -44,6 +44,8 @@ function getViteConfiguration(isDev: boolean) {
},
ssr: {
external: ['babel-preset-solid'],
target: 'node',
noExternal: ['solid-js']
},
};
}