From 2e1d5f8739552c3428aa7cbb82811ed2b9b24fdb Mon Sep 17 00:00:00 2001 From: Arsh <69170106+lilnasy@users.noreply.github.com> Date: Wed, 20 Sep 2023 13:57:46 +0530 Subject: [PATCH] fix(node): report render error to the terminal (#8599) --- .changeset/curly-icons-watch.md | 5 +++++ packages/integrations/node/src/nodeMiddleware.ts | 3 +++ 2 files changed, 8 insertions(+) create mode 100644 .changeset/curly-icons-watch.md diff --git a/.changeset/curly-icons-watch.md b/.changeset/curly-icons-watch.md new file mode 100644 index 000000000..8c2561904 --- /dev/null +++ b/.changeset/curly-icons-watch.md @@ -0,0 +1,5 @@ +--- +'@astrojs/node': patch +--- + +The node adapter now logs uncaught errors encountered during rendering a page. diff --git a/packages/integrations/node/src/nodeMiddleware.ts b/packages/integrations/node/src/nodeMiddleware.ts index 32b8020dc..eaab0790c 100644 --- a/packages/integrations/node/src/nodeMiddleware.ts +++ b/packages/integrations/node/src/nodeMiddleware.ts @@ -51,6 +51,9 @@ export default function (app: NodeApp, mode: Options['mode']) { await writeWebResponse(app, res, response); } } catch (err: unknown) { + const logger = app.getAdapterLogger() + logger.error(`Could not render ${req.url}`) + console.error(err) if (!res.headersSent) { res.writeHead(500, `Server error`); res.end();