michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[Content Collections] Fix import.meta.env.DEV always set to true (#5700)

Browse source 
* fix: reset NODE_ENV on content config read

* fix: move nodeEnv setter above createServer

* chore: changeset
This commit is contained in:
Ben Holmes 2023-01-03 09:45:38 -05:00 • committed by GitHub
parent bf210f7841
commit 3aa3e00a63
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/yellow-gifts-complain.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fix `import.meta.env.DEV` always being set to `true` when using Content Collections

4
packages/astro/src/content/utils.ts
View file

@ -190,6 +190,7 @@ export async function loadContentConfig({
settings: AstroSettings; settings: AstroSettings;
}): Promise<ContentConfig | Error> { }): Promise<ContentConfig | Error> {
const contentPaths = getContentPaths({ srcDir: settings.config.srcDir }); const contentPaths = getContentPaths({ srcDir: settings.config.srcDir });
const nodeEnv = process.env.NODE_ENV;
const tempConfigServer: ViteDevServer = await createServer({ const tempConfigServer: ViteDevServer = await createServer({
root: fileURLToPath(settings.config.root), root: fileURLToPath(settings.config.root),
server: { middlewareMode: true, hmr: false }, server: { middlewareMode: true, hmr: false },
@ -206,6 +207,9 @@ export async function loadContentConfig({
return new NotFoundError('Failed to resolve content config.'); return new NotFoundError('Failed to resolve content config.');
} finally { } finally {
await tempConfigServer.close(); await tempConfigServer.close();
// Reset NODE_ENV to initial value
// Vite's `createServer()` sets NODE_ENV to 'development'!
process.env.NODE_ENV = nodeEnv;
} }
const config = contentConfigParser.safeParse(unparsedConfig); const config = contentConfigParser.safeParse(unparsedConfig);
if (config.success) { if (config.success) {