michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Show warning about hydrating Astro components in build (#5501)

Browse source 
* Also show the warning in build when trying to hydrate an Astro component

* Add changeset
This commit is contained in:
Erika 2022-12-01 12:41:37 -04:00 • committed by GitHub
parent 8450a09f14
commit 3c44033e4e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/yellow-lizards-shout.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Added a warning in build when trying to hydrate an Astro component

4
packages/astro/src/runtime/server/render/astro.ts
View file

@ -8,9 +8,9 @@ import { isPromise } from '../util.js';
import { renderChild } from './any.js'; import { renderChild } from './any.js';
import { HTMLParts } from './common.js'; import { HTMLParts } from './common.js';
// In dev mode, check props and make sure they are valid for an Astro component // Issue warnings for invalid props for Astro components
function validateComponentProps(props: any, displayName: string) { function validateComponentProps(props: any, displayName: string) {
if (import.meta.env?.DEV && props != null) { if (props != null) {
for (const prop of Object.keys(props)) { for (const prop of Object.keys(props)) {
if (HydrationDirectiveProps.has(prop)) { if (HydrationDirectiveProps.has(prop)) {
// eslint-disable-next-line // eslint-disable-next-line