michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: remove astro from noExternal

Browse source
This commit is contained in:
Nate Moore 2021-12-14 15:16:50 -06:00
parent ec6c6169dc
commit 3d7c4b0247
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/astro/src/core/create-vite.ts
View file

@ -19,7 +19,6 @@ const ALWAYS_EXTERNAL = new Set([
...builtinModules.map((name) => `node:${name}`), ...builtinModules.map((name) => `node:${name}`),
'@sveltejs/vite-plugin-svelte', '@sveltejs/vite-plugin-svelte',
'@proload/core', '@proload/core',
require.resolve('@proload/core'),
'@babel/core', '@babel/core',
'babel-plugin-module-resolver', 'babel-plugin-module-resolver',
'serialize-javascript', 'serialize-javascript',
@ -31,9 +30,6 @@ const ALWAYS_EXTERNAL = new Set([
'unified', 'unified',
'whatwg-url', 'whatwg-url',
]); ]);
const ALWAYS_NOEXTERNAL = new Set([
'astro', // This is only because Vite's native ESM doesn't resolve "exports" correctly.
]);
// note: ssr is still an experimental API hence the type omission // note: ssr is still an experimental API hence the type omission
export type ViteConfigWithSSR = vite.InlineConfig & { ssr?: { external?: string[]; noExternal?: string[] } }; export type ViteConfigWithSSR = vite.InlineConfig & { ssr?: { external?: string[]; noExternal?: string[] } };
@ -76,7 +72,7 @@ export async function createVite(inlineConfig: ViteConfigWithSSR, { astroConfig,
// Note: SSR API is in beta (https://vitejs.dev/guide/ssr.html) // Note: SSR API is in beta (https://vitejs.dev/guide/ssr.html)
ssr: { ssr: {
external: [...ALWAYS_EXTERNAL], external: [...ALWAYS_EXTERNAL],
noExternal: [...ALWAYS_NOEXTERNAL], noExternal: [],
}, },
}; };