michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: pnpm failure on create-astro (#7435)

Browse source 
* fix: use which-pm-runs instead of preferred-pm

* deps: remove preferred-pm

* chore: move which-pm-runs to regular deps

* chore: changeset
This commit is contained in:
Ben Holmes 2023-06-21 16:02:20 -04:00 committed by GitHub
parent 30bb363713
commit 3f9f5c117e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/clever-rings-draw.md Normal file
View file

@ -0,0 +1,5 @@
---
'create-astro': patch
---
Fix registry failures using unexpected package managers when running create-astro

5
packages/create-astro/package.json
View file

@ -36,15 +36,14 @@
"execa": "^6.1.0",
"giget": "1.0.0",
"mocha": "^9.2.2",
"preferred-pm": "^3.0.3"
"which-pm-runs": "^1.1.0"
},
"devDependencies": {
"@types/which-pm-runs": "^1.0.0",
"arg": "^5.0.2",
"astro-scripts": "workspace:*",
"strip-ansi": "^7.1.0",
"strip-json-comments": "^5.0.0",
"which-pm-runs": "^1.1.0"
"strip-json-comments": "^5.0.0"
},
"engines": {
"node": ">=16.12.0"

4
packages/create-astro/src/messages.ts
View file

@ -4,15 +4,15 @@ import { align, sleep } from '@astrojs/cli-kit/utils';
import { execa } from 'execa';
import { exec } from 'node:child_process';
import { get } from 'node:https';
import preferredPM from 'preferred-pm';
import stripAnsi from 'strip-ansi';
import detectPackageManager from 'which-pm-runs';
// Users might lack access to the global npm registry, this function
// checks the user's project type and will return the proper npm registry
//
// A copy of this function also exists in the astro package
async function getRegistry(): Promise<string> {
const packageManager = (await preferredPM(process.cwd()))?.name || 'npm';
const packageManager = detectPackageManager()?.name || 'npm';
const { stdout } = await execa(packageManager, ['config', 'get', 'registry']);
return stdout || 'https://registry.npmjs.org';
}

9
pnpm-lock.yaml
View file

@ -3577,9 +3577,9 @@ importers:
mocha:
specifier: ^9.2.2
version: 9.2.2
preferred-pm:
specifier: ^3.0.3
version: 3.0.3
which-pm-runs:
specifier: ^1.1.0
version: 1.1.0
devDependencies:
'@types/which-pm-runs':
specifier: ^1.0.0
@ -3596,9 +3596,6 @@ importers:
strip-json-comments:
specifier: ^5.0.0
version: 5.0.0
which-pm-runs:
specifier: ^1.1.0
version: 1.1.0
packages/create-astro/test/fixtures/not-empty: {}