michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't append a class attribute to the doctype (#284)

Browse source 
* Don't append a class attribute to the doctype

Fixes #282

* Add changeset
This commit is contained in:
Matthew Phillips 2021-06-01 21:03:38 -04:00 committed by GitHub
parent ee5b1ac12f
commit 46871d2d4a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/fast-colts-shout.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fixed bug where a class attribute was added to the doctype

3
packages/astro/src/compiler/transform/postcss-scoped-styles/index.ts
View file

@ -14,8 +14,7 @@ const CSS_SEPARATORS = new Set([' ', ',', '+', '>', '~']);
const KEYFRAME_PERCENT = /\d+\.?\d*%/;
/** HTML tags that should never get scoped classes */
export const NEVER_SCOPED_TAGS = new Set<string>(['base', 'body', 'font', 'frame', 'frameset', 'head', 'html', 'link', 'meta', 'noframes', 'noscript', 'script', 'style', 'title']);
export const NEVER_SCOPED_TAGS = new Set<string>(['base', 'body', 'font', 'frame', 'frameset', 'head', 'html', 'link', 'meta', 'noframes', 'noscript', 'script', 'style', 'title', '!doctype']);
/**
* Scope Rules
* Given a selector string (`.btn>span,.nav>span`), add an additional CSS class to every selector (`.btn.myClass>span.myClass,.nav.myClass>span.myClass`)

8
packages/astro/test/astro-doctype.test.js
View file

@ -40,6 +40,14 @@ DType('Automatically prepends the standards mode doctype', async () => {
assert.ok(html.startsWith('<!doctype html>'), 'Doctype always included');
});
DType('No attributes added when doctype is provided by user', async () => {
const result = await runtime.load('/provided');
if (result.error) throw new Error(result.error);
const html = result.contents.toString('utf-8');
assert.ok(html.startsWith('<!doctype html>'), 'Doctype always included');
});
DType.skip('Preserves user provided doctype', async () => {
const result = await runtime.load('/preserve');
if (result.error) throw new Error(result.error);

9
packages/astro/test/fixtures/astro-doctype/src/pages/provided.astro vendored Normal file
View file

@ -0,0 +1,9 @@
---
let title = 'My Site';
---
<!doctype html>
<html lang="en">
<head><title>{title}</title></head>
<body><h1>Hello world</h1></body>
</html>