From 4b1f5c3dc627e62b78a6993f502a35712cb9f400 Mon Sep 17 00:00:00 2001 From: "Fred K. Schott" Date: Tue, 13 Jul 2021 10:57:40 -0400 Subject: [PATCH] code review comments --- .changeset/lovely-kids-sniff.md | 17 ----------------- .../src/pages/$author.astro | 3 +-- .../src/pages/$posts.astro | 3 +-- .../blog-multiple-authors/src/pages/about.astro | 3 +-- .../blog-multiple-authors/src/pages/index.astro | 3 +-- examples/blog/src/pages/index.astro | 3 +-- .../framework-multiple/src/pages/index.astro | 3 +-- examples/framework-preact/src/pages/index.astro | 3 +-- examples/framework-react/src/pages/index.astro | 3 +-- examples/framework-svelte/src/pages/index.astro | 3 +-- examples/framework-vue/src/pages/index.astro | 3 +-- examples/portfolio/src/pages/$projects.astro | 3 +-- examples/portfolio/src/pages/404.astro | 3 +-- examples/portfolio/src/pages/about.astro | 3 +-- examples/portfolio/src/pages/index.astro | 3 +-- examples/snowpack/src/pages/404.astro | 3 +-- examples/snowpack/src/pages/guides.astro | 3 +-- examples/snowpack/src/pages/index.astro | 3 +-- examples/snowpack/src/pages/news.astro | 3 +-- examples/snowpack/src/pages/plugins.astro | 3 +-- .../[slug].astro.ignore | 3 +-- examples/starter/src/pages/index.astro | 3 +-- examples/with-nanostores/src/pages/index.astro | 3 +-- examples/with-tailwindcss/src/pages/index.astro | 3 +-- 24 files changed, 23 insertions(+), 63 deletions(-) delete mode 100644 .changeset/lovely-kids-sniff.md diff --git a/.changeset/lovely-kids-sniff.md b/.changeset/lovely-kids-sniff.md deleted file mode 100644 index 23c585acc..000000000 --- a/.changeset/lovely-kids-sniff.md +++ /dev/null @@ -1,17 +0,0 @@ ---- -'@example/blog': minor -'@example/blog-multiple-authors': minor -'@example/docs': minor -'@example/framework-multiple': minor -'@example/framework-preact': minor -'@example/framework-react': minor -'@example/framework-svelte': minor -'@example/framework-vue': minor -'@example/portfolio': minor -'@example/snowpack': minor -'@example/with-markdown': minor -'@example/with-markdown-plugins': minor -'@example/with-tailwindcss': minor ---- - -Add lang attribute to html tags diff --git a/examples/blog-multiple-authors/src/pages/$author.astro b/examples/blog-multiple-authors/src/pages/$author.astro index bcd9d76af..e0a6a1919 100644 --- a/examples/blog-multiple-authors/src/pages/$author.astro +++ b/examples/blog-multiple-authors/src/pages/$author.astro @@ -8,7 +8,6 @@ import Pagination from '../components/Pagination.astro'; let title = 'Don’s Blog'; let description = 'An example blog on Astro'; let canonicalURL = Astro.request.canonicalURL; -let lang = 'en'; // collection import authorData from '../data/authors.json'; @@ -46,7 +45,7 @@ export async function createCollection() { const author = authorData[collection.params.author]; --- - + {title} + {title} + + {title} new Date(b.publishDate) - new Date(a.publishD // Full Astro Component Syntax: // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md --- - + diff --git a/examples/framework-multiple/src/pages/index.astro b/examples/framework-multiple/src/pages/index.astro index 0b6a8ad6d..706e4863f 100644 --- a/examples/framework-multiple/src/pages/index.astro +++ b/examples/framework-multiple/src/pages/index.astro @@ -6,12 +6,11 @@ import { PreactCounter } from '../components/PreactCounter.tsx'; import VueCounter from '../components/VueCounter.vue'; import SvelteCounter from '../components/SvelteCounter.svelte'; -let lang = 'en'; // Full Astro Component Syntax: // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md --- - + diff --git a/examples/framework-preact/src/pages/index.astro b/examples/framework-preact/src/pages/index.astro index 513c43b43..ed42e72fd 100644 --- a/examples/framework-preact/src/pages/index.astro +++ b/examples/framework-preact/src/pages/index.astro @@ -2,12 +2,11 @@ // Component Imports import Counter from '../components/Counter.jsx' -let lang = 'en'; // Full Astro Component Syntax: // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md --- - + + + + +