From 51d5dc478993a994268391a5f13eec32ae29f665 Mon Sep 17 00:00:00 2001 From: Tony Sullivan Date: Wed, 29 Jun 2022 20:56:51 +0000 Subject: [PATCH] Updates an error handler to expect updated `@astrojs/lit` behavior (#3766) * fix: don't throw an error when the lit renderer doesn't provide a clientEntrypoint * updating the framework-lit example to match new behavior * fix: updating the playground example to latest lit syntax --- .../framework-lit/src/components/{Test.js => calc-add.js} | 6 ++---- .../src/components/{Counter.js => my-counter.js} | 6 ++---- examples/framework-lit/src/pages/index.astro | 8 ++++---- .../src/components/{Test.js => calc-add.js} | 6 ++---- .../src/components/{Counter.js => my-counter.js} | 6 ++---- examples/integrations-playground/src/pages/index.astro | 8 ++++---- packages/astro/src/runtime/server/index.ts | 4 +++- 7 files changed, 19 insertions(+), 25 deletions(-) rename examples/framework-lit/src/components/{Test.js => calc-add.js} (62%) rename examples/framework-lit/src/components/{Counter.js => my-counter.js} (76%) rename examples/integrations-playground/src/components/{Test.js => calc-add.js} (62%) rename examples/integrations-playground/src/components/{Counter.js => my-counter.js} (76%) diff --git a/examples/framework-lit/src/components/Test.js b/examples/framework-lit/src/components/calc-add.js similarity index 62% rename from examples/framework-lit/src/components/Test.js rename to examples/framework-lit/src/components/calc-add.js index 7f565f777..b0b3978bf 100644 --- a/examples/framework-lit/src/components/Test.js +++ b/examples/framework-lit/src/components/calc-add.js @@ -1,8 +1,6 @@ import { LitElement, html } from 'lit'; -export const tagName = 'calc-add'; - -class CalcAdd extends LitElement { +export class CalcAdd extends LitElement { static get properties() { return { num: { @@ -16,4 +14,4 @@ class CalcAdd extends LitElement { } } -customElements.define(tagName, CalcAdd); +customElements.define('calc-add', CalcAdd); diff --git a/examples/framework-lit/src/components/Counter.js b/examples/framework-lit/src/components/my-counter.js similarity index 76% rename from examples/framework-lit/src/components/Counter.js rename to examples/framework-lit/src/components/my-counter.js index 35fa8dbbb..adc9e4a3d 100644 --- a/examples/framework-lit/src/components/Counter.js +++ b/examples/framework-lit/src/components/my-counter.js @@ -1,8 +1,6 @@ import { LitElement, html } from 'lit'; -export const tagName = 'my-counter'; - -class Counter extends LitElement { +export class MyCounter extends LitElement { static get properties() { return { count: { @@ -31,4 +29,4 @@ class Counter extends LitElement { } } -customElements.define(tagName, Counter); +customElements.define('my-counter', MyCounter); diff --git a/examples/framework-lit/src/pages/index.astro b/examples/framework-lit/src/pages/index.astro index 6b825848e..3f45d057f 100644 --- a/examples/framework-lit/src/pages/index.astro +++ b/examples/framework-lit/src/pages/index.astro @@ -1,7 +1,7 @@ --- import Lorem from '../components/Lorem.astro'; -import '../components/Test.js'; -import '../components/Counter.js'; +import { CalcAdd } from '../components/calc-add.js'; +import { MyCounter } from '../components/my-counter.js'; --- @@ -12,8 +12,8 @@ import '../components/Counter.js';

Test app

- + - + diff --git a/examples/integrations-playground/src/components/Test.js b/examples/integrations-playground/src/components/calc-add.js similarity index 62% rename from examples/integrations-playground/src/components/Test.js rename to examples/integrations-playground/src/components/calc-add.js index 7f565f777..b0b3978bf 100644 --- a/examples/integrations-playground/src/components/Test.js +++ b/examples/integrations-playground/src/components/calc-add.js @@ -1,8 +1,6 @@ import { LitElement, html } from 'lit'; -export const tagName = 'calc-add'; - -class CalcAdd extends LitElement { +export class CalcAdd extends LitElement { static get properties() { return { num: { @@ -16,4 +14,4 @@ class CalcAdd extends LitElement { } } -customElements.define(tagName, CalcAdd); +customElements.define('calc-add', CalcAdd); diff --git a/examples/integrations-playground/src/components/Counter.js b/examples/integrations-playground/src/components/my-counter.js similarity index 76% rename from examples/integrations-playground/src/components/Counter.js rename to examples/integrations-playground/src/components/my-counter.js index 35fa8dbbb..adc9e4a3d 100644 --- a/examples/integrations-playground/src/components/Counter.js +++ b/examples/integrations-playground/src/components/my-counter.js @@ -1,8 +1,6 @@ import { LitElement, html } from 'lit'; -export const tagName = 'my-counter'; - -class Counter extends LitElement { +export class MyCounter extends LitElement { static get properties() { return { count: { @@ -31,4 +29,4 @@ class Counter extends LitElement { } } -customElements.define(tagName, Counter); +customElements.define('my-counter', MyCounter); diff --git a/examples/integrations-playground/src/pages/index.astro b/examples/integrations-playground/src/pages/index.astro index 06c9aa3d8..66475f3e7 100644 --- a/examples/integrations-playground/src/pages/index.astro +++ b/examples/integrations-playground/src/pages/index.astro @@ -2,8 +2,8 @@ import Lorem from '../components/Lorem.astro'; import Link from '../components/Link.jsx'; import SolidCounter from '../components/SolidCounter.jsx'; -import '../components/Test.js'; -import '../components/Counter.js'; +import { CalcAdd } from '../components/calc-add.js'; +import { MyCounter } from '../components/my-counter.js'; --- @@ -18,11 +18,11 @@ import '../components/Counter.js'; Party Mode! Colors changing = partytown is enabled - + - +