From 5fe52737cbb3676af69bb446afa7f3b53b78dc34 Mon Sep 17 00:00:00 2001 From: Nate Moore Date: Fri, 1 Jul 2022 16:51:28 -0400 Subject: [PATCH] Update MDX example to address failure (#3799) * fix: do not use symbol in JSX runtime * chore: update MDX example Co-authored-by: Nate Moore --- .changeset/cyan-balloons-battle.md | 5 +++++ examples/with-mdx/.vscode/extensions.json | 5 ++++- examples/with-mdx/src/pages/index.mdx | 8 +++++--- packages/astro/src/jsx-runtime/index.ts | 2 +- 4 files changed, 15 insertions(+), 5 deletions(-) create mode 100644 .changeset/cyan-balloons-battle.md diff --git a/.changeset/cyan-balloons-battle.md b/.changeset/cyan-balloons-battle.md new file mode 100644 index 000000000..311de685d --- /dev/null +++ b/.changeset/cyan-balloons-battle.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +Fix internal error for MDX integration diff --git a/examples/with-mdx/.vscode/extensions.json b/examples/with-mdx/.vscode/extensions.json index 22a15055d..83f84bb61 100644 --- a/examples/with-mdx/.vscode/extensions.json +++ b/examples/with-mdx/.vscode/extensions.json @@ -1,4 +1,7 @@ { - "recommendations": ["astro-build.astro-vscode"], + "recommendations": [ + "astro-build.astro-vscode", + "silvenon.mdx" + ], "unwantedRecommendations": [] } diff --git a/examples/with-mdx/src/pages/index.mdx b/examples/with-mdx/src/pages/index.mdx index cbd392371..cedcac1dd 100644 --- a/examples/with-mdx/src/pages/index.mdx +++ b/examples/with-mdx/src/pages/index.mdx @@ -2,16 +2,18 @@ import Counter from '../components/Counter.jsx'; import Title from '../components/Title.astro'; export const components = { h1: Title }; -# Hello world! - export const authors = [ { name: 'Jane', email: 'hi@jane.com' }, { name: 'John', twitter: '@john2002' }, ]; export const published = new Date('2022-02-01'); +# Hello world! + Written by: {new Intl.ListFormat('en').format(authors.map(d => d.name))}. Published on: {new Intl.DateTimeFormat('en', {dateStyle: 'long'}).format(published)}. -## Counter + + ## This is a counter! + diff --git a/packages/astro/src/jsx-runtime/index.ts b/packages/astro/src/jsx-runtime/index.ts index b257d2ab5..92c26ac76 100644 --- a/packages/astro/src/jsx-runtime/index.ts +++ b/packages/astro/src/jsx-runtime/index.ts @@ -1,6 +1,6 @@ import { Fragment, markHTMLString } from '../runtime/server/index.js'; -const AstroJSX = Symbol('@astrojs/jsx'); +const AstroJSX = 'astro:jsx'; const Empty = Symbol('empty'); interface AstroVNode {