michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Re-enable error recovery test (#3396)

Browse source 
* Re-enable error recovery test

* Doing some debugging

* Remove extra debugging

* longer wait

* make it wait even longer just to check

* Wait a very long time

* await the change, and then a little bit

* Give a longer timeout for the error recovery test

* OK, make it *very* long

* Run error tests separately

* Get rid of wait
This commit is contained in:
Matthew Phillips 2022-05-18 11:20:06 -04:00 committed by GitHub
parent ef32b7c39c
commit 6cec1b8ef2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/astro/package.json
View file

@ -71,7 +71,7 @@
"dev": "astro-scripts dev \"src/**/*.ts\"", "dev": "astro-scripts dev \"src/**/*.ts\"",
"postbuild": "astro-scripts copy \"src/**/*.astro\"", "postbuild": "astro-scripts copy \"src/**/*.astro\"",
"benchmark": "node test/benchmark/dev.bench.js && node test/benchmark/build.bench.js", "benchmark": "node test/benchmark/dev.bench.js && node test/benchmark/build.bench.js",
"test": "mocha --exit --timeout 20000 --ignore **/lit-element.test.js && mocha --timeout 20000 **/lit-element.test.js", "test": "mocha --exit --timeout 20000 --ignore **/lit-element.test.js --ignore **/errors.test.js && mocha --timeout 20000 **/lit-element.test.js && mocha --timeout 20000 **/errors.test.js",
"test:match": "mocha --timeout 20000 -g", "test:match": "mocha --timeout 20000 -g",
"test:e2e": "playwright test e2e" "test:e2e": "playwright test e2e"
}, },

6
packages/astro/test/errors.test.js
View file

@ -5,6 +5,7 @@ import * as cheerio from 'cheerio';
describe('Error display', () => { describe('Error display', () => {
if (isWindows) return; if (isWindows) return;
/** @type {import('./test-utils').Fixture} */
let fixture; let fixture;
let devServer; let devServer;
@ -32,7 +33,7 @@ describe('Error display', () => {
}); });
}); });
describe('Framework components', () => { describe('Framework components', function() {
let devServer; let devServer;
before(async () => { before(async () => {
@ -43,8 +44,7 @@ describe('Error display', () => {
await devServer.stop(); await devServer.stop();
}); });
// Skip until https://github.com/withastro/astro/pull/3376 is revisited it('Errors recover when fixed', async () => {
it.skip('Errors recover when fixed', async () => {
let html = await fixture.fetch('/svelte-syntax-error').then((res) => res.text()); let html = await fixture.fetch('/svelte-syntax-error').then((res) => res.text());
// 1. Verify an error message is being shown. // 1. Verify an error message is being shown.

1
packages/astro/test/test-utils.js
View file

@ -33,6 +33,7 @@ polyfill(globalThis, {
* @property {() => Promise<PreviewServer>} preview * @property {() => Promise<PreviewServer>} preview
* @property {() => Promise<void>} clean * @property {() => Promise<void>} clean
* @property {() => Promise<App>} loadTestAdapterApp * @property {() => Promise<App>} loadTestAdapterApp
* @property {() => Promise<void>} onNextChange
*/ */
/** /**