michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: address feedback from #7754 (#7906)

Browse source
This commit is contained in:
Nate Moore 2023-08-01 13:24:02 -05:00 committed by GitHub
parent 1d9e34b136
commit 70bbec9c61
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/astro/src/core/app/index.ts
View file

@ -273,7 +273,7 @@ export class App {
} }
/** /**
* If is a known error code, try sending the according page (e.g. 404.astro / 500.astro). * If it is a known error code, try sending the according page (e.g. 404.astro / 500.astro).
* This also handles pre-rendered /404 or /500 routes * This also handles pre-rendered /404 or /500 routes
*/ */
async #renderError( async #renderError(
@ -319,8 +319,10 @@ export class App {
const { status, statusText, headers } = oldResponse; const { status, statusText, headers } = oldResponse;
return new Response(newResponse.body, { return new Response(newResponse.body, {
// If the original status was 200 (default), override it with the new status (probably 404 or 500)
// Otherwise, the user set a specific status while rendering and we should respect that one
status: status === 200 ? newResponse.status : status, status: status === 200 ? newResponse.status : status,
statusText, statusText: status === 200 ? newResponse.statusText : statusText,
headers: new Headers(Array.from(headers)), headers: new Headers(Array.from(headers)),
}); });
} }