From 73f367c77b8311707b1c142e03dd53952f14d934 Mon Sep 17 00:00:00 2001 From: "Fred K. Schott" Date: Sat, 13 Aug 2022 00:09:58 -0700 Subject: [PATCH] add protection if astro preview is run with server output (#4284) Co-authored-by: Nate Moore --- .changeset/yellow-insects-add.md | 5 +++++ packages/astro/src/cli/index.ts | 2 +- packages/astro/src/core/preview/index.ts | 3 +++ packages/astro/test/cli.test.js | 3 +-- 4 files changed, 10 insertions(+), 3 deletions(-) create mode 100644 .changeset/yellow-insects-add.md diff --git a/.changeset/yellow-insects-add.md b/.changeset/yellow-insects-add.md new file mode 100644 index 000000000..7454f9c4c --- /dev/null +++ b/.changeset/yellow-insects-add.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +Prevent preview if 'output: server' is configured diff --git a/packages/astro/src/cli/index.ts b/packages/astro/src/cli/index.ts index d1e85301f..2511ada86 100644 --- a/packages/astro/src/cli/index.ts +++ b/packages/astro/src/cli/index.ts @@ -37,7 +37,7 @@ function printAstroHelp() { printHelp({ commandName: 'astro', usage: '[command] [...flags]', - headline: 'Futuristic web development tool.', + headline: 'Build faster websites.', tables: { Commands: [ ['add', 'Add an integration.'], diff --git a/packages/astro/src/core/preview/index.ts b/packages/astro/src/core/preview/index.ts index 33392831c..9453fdf65 100644 --- a/packages/astro/src/core/preview/index.ts +++ b/packages/astro/src/core/preview/index.ts @@ -33,6 +33,9 @@ export default async function preview( config: AstroConfig, { logging }: PreviewOptions ): Promise { + if (config.output === 'server') { + throw new Error(`[preview] 'output: server' not supported. Use your deploy platform's preview command directly instead, if one exists. (ex: 'netlify dev', 'vercel dev', 'wrangler', etc.)`); + } const startServerTime = performance.now(); const defaultOrigin = 'http://localhost'; const trailingSlash = config.trailingSlash; diff --git a/packages/astro/test/cli.test.js b/packages/astro/test/cli.test.js index 38d8964c2..50364bd57 100644 --- a/packages/astro/test/cli.test.js +++ b/packages/astro/test/cli.test.js @@ -12,8 +12,7 @@ describe('astro cli', () => { it('astro', async () => { const proc = await cli(); - - expect(proc.stdout).to.include('Futuristic web development tool'); + expect(proc.exitCode).to.equal(0); }); it('astro --version', async () => {