michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Preserve all error stack lines (#4364)

Browse source
This commit is contained in:
Bjorn Lu 2022-08-18 14:36:31 +08:00 committed by GitHub
parent 41b81d0d7e
commit 77b068086d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/rare-comics-roll.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Preserve all error stack lines

1
packages/astro/src/core/errors.ts
View file

@ -37,7 +37,6 @@ export interface ErrorWithMetadata {
export function cleanErrorStack(stack: string) { export function cleanErrorStack(stack: string) {
return stack return stack
.split(/\n/g) .split(/\n/g)
.filter((l) => /^\s*at/.test(l))
.map((l) => l.replace(/\/@fs\//g, '/')) .map((l) => l.replace(/\/@fs\//g, '/'))
.join('\n'); .join('\n');
} }

6
packages/astro/src/core/messages.ts
View file

@ -18,7 +18,7 @@ import type { AddressInfo } from 'net';
import os from 'os'; import os from 'os';
import { ZodError } from 'zod'; import { ZodError } from 'zod';
import type { AstroConfig } from '../@types/astro'; import type { AstroConfig } from '../@types/astro';
import { cleanErrorStack, ErrorWithMetadata } from './errors.js'; import { ErrorWithMetadata } from './errors.js';
import { emoji, getLocalAddress, padMultilineString } from './util.js'; import { emoji, getLocalAddress, padMultilineString } from './util.js';
const PREFIX_PADDING = 6; const PREFIX_PADDING = 6;
@ -235,10 +235,10 @@ export function formatErrorMessage(err: ErrorWithMetadata, args: string[] = []):
args.push(red(padMultilineString(err.frame, 4))); args.push(red(padMultilineString(err.frame, 4)));
} }
if (args.length === 1 && err.stack) { if (args.length === 1 && err.stack) {
args.push(dim(cleanErrorStack(err.stack))); args.push(dim(err.stack));
} else if (err.stack) { } else if (err.stack) {
args.push(` ${bold('Stacktrace:')}`); args.push(` ${bold('Stacktrace:')}`);
args.push(dim(cleanErrorStack(err.stack))); args.push(dim(err.stack));
args.push(``); args.push(``);
} }
return args.join('\n'); return args.join('\n');