From 7d9eb01c8c431bcd43e80d45b155f05f299262ab Mon Sep 17 00:00:00 2001
From: bholmesdev <hey@bholmes.dev>
Date: Wed, 1 Mar 2023 13:35:53 -0500
Subject: [PATCH] refactor: move markdoc transform to build time

---
 examples/with-markdoc/astro.config.mjs        | 17 +++++++++-
 .../src/components/DocsContent.astro          | 13 --------
 packages/integrations/markdoc/src/index.ts    | 31 ++++++++++++++-----
 .../template/content-module-types.d.ts        |  1 -
 4 files changed, 40 insertions(+), 22 deletions(-)

diff --git a/examples/with-markdoc/astro.config.mjs b/examples/with-markdoc/astro.config.mjs
index 29d846359..397c81b9c 100644
--- a/examples/with-markdoc/astro.config.mjs
+++ b/examples/with-markdoc/astro.config.mjs
@@ -3,5 +3,20 @@ import markdoc from '@astrojs/markdoc';
 
 // https://astro.build/config
 export default defineConfig({
-	integrations: [markdoc()],
+	integrations: [
+		markdoc({
+			variables: {
+				revealSecret: true,
+			},
+			tags: {
+				aside: {
+					render: 'Aside',
+					attributes: {
+						type: { type: String },
+						title: { type: String },
+					},
+				},
+			},
+		}),
+	],
 });
diff --git a/examples/with-markdoc/src/components/DocsContent.astro b/examples/with-markdoc/src/components/DocsContent.astro
index 642a62e9c..2ab5752e9 100644
--- a/examples/with-markdoc/src/components/DocsContent.astro
+++ b/examples/with-markdoc/src/components/DocsContent.astro
@@ -11,19 +11,6 @@ const { Content } = await entry.render();
 ---
 
 <Content
-	config={{
-		// Accepts all Markdoc configuration options
-		// See https://markdoc.dev/docs/config#full-example
-		tags: {
-			aside: {
-				render: 'Aside',
-				attributes: {
-					type: { type: String },
-					title: { type: String },
-				},
-			},
-		},
-	}}
 	components={{
 		// Pass a mapping from the component name
 		// To an Astro or UI component import
diff --git a/packages/integrations/markdoc/src/index.ts b/packages/integrations/markdoc/src/index.ts
index ed260563b..75514d596 100644
--- a/packages/integrations/markdoc/src/index.ts
+++ b/packages/integrations/markdoc/src/index.ts
@@ -1,20 +1,22 @@
 import type { AstroIntegration } from 'astro';
 import type { InlineConfig } from 'vite';
-import type { Config as _MarkdocConfig } from '@markdoc/markdoc';
+import type { Config, Config as _MarkdocConfig } from '@markdoc/markdoc';
 import _Markdoc from '@markdoc/markdoc';
 import { parseFrontmatter } from './utils.js';
 import { fileURLToPath } from 'node:url';
 import fs from 'node:fs';
 
-export default function markdoc(): AstroIntegration {
+export default function markdoc(markdocConfig: Config): AstroIntegration {
+	const entryBodyByFileIdCache = new Map<string, string>();
 	return {
 		name: '@astrojs/markdoc',
 		hooks: {
-			'astro:config:setup': async ({ updateConfig, config, addContentEntryType, command }: any) => {
+			'astro:config:setup': async ({ updateConfig, config, addContentEntryType }: any) => {
 				const contentEntryType = {
 					extensions: ['.mdoc'],
-					async getEntryInfo({ fileUrl, contents }: { fileUrl: URL; contents: string }) {
+					getEntryInfo({ fileUrl, contents }: { fileUrl: URL; contents: string }) {
 						const parsed = parseFrontmatter(contents, fileURLToPath(fileUrl));
+						entryBodyByFileIdCache.set(fileUrl.pathname, parsed.content);
 						return {
 							data: parsed.data,
 							body: parsed.content,
@@ -35,9 +37,24 @@ export default function markdoc(): AstroIntegration {
 							name: '@astrojs/markdoc',
 							async transform(code, id) {
 								if (!id.endsWith('.mdoc')) return;
-								return `import { jsx as h } from 'astro/jsx-runtime';\nimport { Markdoc } from '@astrojs/markdoc';\nimport { Renderer } from '@astrojs/markdoc/components';\nexport const body = ${JSON.stringify(
-									code
-								)};\nexport function getParsed() { return Markdoc.parse(body); }\nexport function getTransformed(inlineConfig) { return Markdoc.transform(getParsed(), inlineConfig) }\nexport async function Content ({ config, components }) { return h(Renderer, { content: getTransformed(config), components }); }\nContent[Symbol.for('astro.needsHeadRendering')] = true;`;
+
+								const body = entryBodyByFileIdCache.get(id);
+								if (!body) {
+									// Cache entry should exist if `getCollection()` was called
+									// (see `getEntryInfo()` above)
+									// If not, the user probably tried to import directly.
+									throw new Error(
+										`Unable to render ${JSON.stringify(
+											id.replace(config.root.pathname, '')
+										)}. If you tried to import this file directly, please use a Content Collection query instead. See https://docs.astro.build/en/guides/content-collections/#rendering-content-to-html for more information.`
+									);
+								}
+								const rawAst = Markdoc.parse(body);
+								const ast = Markdoc.transform(rawAst, markdocConfig);
+
+								return `import { jsx as h } from 'astro/jsx-runtime';\nimport { Markdoc } from '@astrojs/markdoc';\nimport { Renderer } from '@astrojs/markdoc/components';\nconst ast = ${JSON.stringify(
+									ast
+								)};\nexport async function Content ({ components }) { return h(Renderer, { content: ast, components }); }\nContent[Symbol.for('astro.needsHeadRendering')] = true;`;
 							},
 						},
 					],
diff --git a/packages/integrations/markdoc/template/content-module-types.d.ts b/packages/integrations/markdoc/template/content-module-types.d.ts
index 528c7db7e..a3a4b19c3 100644
--- a/packages/integrations/markdoc/template/content-module-types.d.ts
+++ b/packages/integrations/markdoc/template/content-module-types.d.ts
@@ -12,7 +12,6 @@ declare module 'astro:content' {
 	interface Render {
 		'.mdoc': Promise<{
 			Content(props: {
-				config?: import('@astrojs/markdoc').MarkdocConfig;
 				components?: Record<string, ComponentRenderer>;
 			}): import('astro').MarkdownInstance<{}>['Content'];
 		}>;