michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix invalid hook usage for exports (#4385)

Browse source 
* Add proper support functional components exports

* Add changeset

* Add support for `export default X`
This commit is contained in:
Kiril Shevchuk 2022-08-23 15:46:51 +03:00 committed by GitHub
parent b2e976f39c
commit 8164fa6f1a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/flat-ads-lay.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fix warning when using hooks inside the react components not exported as a function declaration

45
packages/astro/src/vite-plugin-jsx/tag.ts
View file

@ -55,21 +55,38 @@ export default function tagExportsWithRenderer({
if (node.exportKind === 'type') return;
if (node.type === 'ExportAllDeclaration') return;
if (node.type === 'ExportNamedDeclaration') {
if (t.isFunctionDeclaration(node.declaration)) {
if (node.declaration.id?.name) {
const id = node.declaration.id.name;
const tags = state.get('astro:tags') ?? [];
state.set('astro:tags', [...tags, id]);
}
const addTag = (id: string) => {
const tags = state.get('astro:tags') ?? [];
state.set('astro:tags', [...tags, id]);
}
if (node.type === 'ExportNamedDeclaration' || node.type === 'ExportDefaultDeclaration') {
if (t.isIdentifier(node.declaration)) {
addTag(node.declaration.name);
}
} else if (node.type === 'ExportDefaultDeclaration') {
if (t.isFunctionDeclaration(node.declaration)) {
if (node.declaration.id?.name) {
const id = node.declaration.id.name;
const tags = state.get('astro:tags') ?? [];
state.set('astro:tags', [...tags, id]);
}
else if (t.isFunctionDeclaration(node.declaration) && node.declaration.id?.name) {
addTag(node.declaration.id.name);
}
else if (t.isVariableDeclaration(node.declaration)) {
node.declaration.declarations?.forEach(declaration => {
if (t.isArrowFunctionExpression(declaration.init) && t.isIdentifier(declaration.id)) {
addTag(declaration.id.name);
}
});
}
else if (t.isObjectExpression(node.declaration)) {
node.declaration.properties?.forEach(property => {
if (t.isProperty(property) && t.isIdentifier(property.key)) {
addTag(property.key.name);
}
});
}
else if (t.isExportNamedDeclaration(node)) {
node.specifiers.forEach(specifier => {
if (t.isExportSpecifier(specifier) && t.isIdentifier(specifier.exported)) {
addTag(specifier.local.name);
}
});
}
}
},