michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: avoid infinite loops in crawlCSS (#1956)

Browse source
This commit is contained in:
Nate Moore 2021-11-22 07:47:14 -06:00 • committed by GitHub
parent 902405f4a3
commit 8775730eb9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/six-rockets-jump.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fix CSS scanning bug that could lead to infinite loops

3
packages/astro/src/core/ssr/css.ts
View file

@ -18,6 +18,9 @@ export function getStylesForURL(filePath: URL, viteServer: vite.ViteDevServer):
function crawlCSS(entryModule: string, scanned = new Set<string>()) { function crawlCSS(entryModule: string, scanned = new Set<string>()) {
const moduleName = idToModuleMap.get(entryModule); const moduleName = idToModuleMap.get(entryModule);
if (!moduleName) return; if (!moduleName) return;
if (!moduleName.id) return;
// mark the entrypoint as scanned to avoid an infinite loop
scanned.add(moduleName.id)
for (const importedModule of moduleName.importedModules) { for (const importedModule of moduleName.importedModules) {
if (!importedModule.id || scanned.has(importedModule.id)) continue; if (!importedModule.id || scanned.has(importedModule.id)) continue;
const ext = path.extname(importedModule.id.toLowerCase()); const ext = path.extname(importedModule.id.toLowerCase());