michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(deno): do not set vite.ssr.noExternal (#8652)

Browse source 
* fix(deno): safely set external specifiers

* noExternal does not need to be manually set at all
This commit is contained in:
Arsh 2023-09-25 13:43:43 +00:00 committed by GitHub
parent 211bfe3b00
commit 954cadc1e5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/spotty-dryers-exist.md Normal file
View file

@ -0,0 +1,5 @@
---
'@astrojs/deno': patch
---
Fixed an issue where deno integration broke some frameworks.

4
packages/integrations/deno/src/index.ts
View file

@ -130,6 +130,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
`[@astrojs/deno] Otherwise, this adapter is not required to deploy a static site to Deno.` `[@astrojs/deno] Otherwise, this adapter is not required to deploy a static site to Deno.`
); );
} }
}, },
'astro:build:setup': ({ vite, target }) => { 'astro:build:setup': ({ vite, target }) => {
if (target === 'server') { if (target === 'server') {
@ -149,9 +150,6 @@ export default function createIntegration(args?: Options): AstroIntegration {
(vite.resolve.alias as Record<string, string>)[alias.find] = alias.replacement; (vite.resolve.alias as Record<string, string>)[alias.find] = alias.replacement;
} }
} }
vite.ssr = {
noExternal: COMPATIBLE_NODE_MODULES,
};
if (Array.isArray(vite.build.rollupOptions.external)) { if (Array.isArray(vite.build.rollupOptions.external)) {
vite.build.rollupOptions.external.push(DENO_IMPORTS_SHIM); vite.build.rollupOptions.external.push(DENO_IMPORTS_SHIM);