michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: no deletion of scripts during view transition (#8636)

Browse source
This commit is contained in:
Martin Trapp 2023-09-22 18:01:22 +02:00 committed by GitHub
parent 0352dec47b
commit 974d5117ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/short-cougars-worry.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
fix: no deletion of scripts during view transition

10
packages/astro/components/ViewTransitions.astro
View file

@ -219,13 +219,13 @@ const { fallback = 'animate' } = Astro.props as Props;
for (const s2 of newDocument.scripts) {
if (
// Inline
(s1.textContent && s1.textContent === s2.textContent) ||
(!s1.src && s1.textContent === s2.textContent) ||
// External
(s1.type === s2.type && s1.src === s2.src)
(s1.src && s1.type === s2.type && s1.src === s2.src)
) {
s2.remove();
} else {
s1.remove();
// the old script is in the new document: we mark it as executed to prevent re-execution
s2.dataset.astroExec = '';
break;
}
}
}