From 998f412c57696a9beaeb145b603d2837c22e2e22 Mon Sep 17 00:00:00 2001 From: Bjorn Lu Date: Tue, 17 Jan 2023 11:17:59 +0800 Subject: [PATCH] Revert "Add missing `noPropertyAccessFromIndexSignature` to strictest tsconfig profile (#5864)" (#5876) This reverts commit 63d5d89038dc8cddf0a137672b68f61a21bb4951. --- .changeset/smooth-cycles-sing.md | 7 ------- packages/astro/tsconfigs/strictest.json | 2 -- 2 files changed, 9 deletions(-) delete mode 100644 .changeset/smooth-cycles-sing.md diff --git a/.changeset/smooth-cycles-sing.md b/.changeset/smooth-cycles-sing.md deleted file mode 100644 index d00bf0331..000000000 --- a/.changeset/smooth-cycles-sing.md +++ /dev/null @@ -1,7 +0,0 @@ ---- -'astro': patch ---- - -The `noPropertyAccessFromIndexSignature` typescript configuration option was added to the `strictest` profile. - -This will have no impact at runtime, but may affect code checks on codebases which do not already use this check. diff --git a/packages/astro/tsconfigs/strictest.json b/packages/astro/tsconfigs/strictest.json index adabf0142..f59dc4f6c 100644 --- a/packages/astro/tsconfigs/strictest.json +++ b/packages/astro/tsconfigs/strictest.json @@ -8,8 +8,6 @@ "noImplicitOverride": true, // Force functions to specify that they can return `undefined` if a possible code path does not return a value. "noImplicitReturns": true, - // Ensures consistency between accessing a field via the “dot” (obj.key) syntax, and “indexed” (obj["key"]) and the way which the property is declared in the type. - "noPropertyAccessFromIndexSignature": true, // Report an error when a variable is declared but never used. "noUnusedLocals": true, // Report an error when a parameter is declared but never used.