michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert "Add missing noPropertyAccessFromIndexSignature to strictest tsconfig profile (#5864)" (#5876)

Browse source 
This reverts commit 63d5d89038.
This commit is contained in:
Bjorn Lu 2023-01-17 11:17:59 +08:00 committed by GitHub
parent 63d5d89038
commit 998f412c57
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.changeset/smooth-cycles-sing.md
View file

@ -1,7 +0,0 @@
---
'astro': patch
---
The `noPropertyAccessFromIndexSignature` typescript configuration option was added to the `strictest` profile.
This will have no impact at runtime, but may affect code checks on codebases which do not already use this check.

2
packages/astro/tsconfigs/strictest.json
View file

@ -8,8 +8,6 @@
"noImplicitOverride": true, "noImplicitOverride": true,
// Force functions to specify that they can return `undefined` if a possible code path does not return a value. // Force functions to specify that they can return `undefined` if a possible code path does not return a value.
"noImplicitReturns": true, "noImplicitReturns": true,
// Ensures consistency between accessing a field via the “dot” (obj.key) syntax, and “indexed” (obj["key"]) and the way which the property is declared in the type.
"noPropertyAccessFromIndexSignature": true,
// Report an error when a variable is declared but never used. // Report an error when a variable is declared but never used.
"noUnusedLocals": true, "noUnusedLocals": true,
// Report an error when a parameter is declared but never used. // Report an error when a parameter is declared but never used.