michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add console warning on fs.strict=false (#3464)

Browse source 
* chore: add warning on fs.strict=false

* chore: add changeset

Co-authored-by: Nate Moore <nate@skypack.dev>
This commit is contained in:
Ben Holmes 2022-06-01 18:32:29 -04:00 committed by GitHub
parent 5c32c7a4c3
commit 9c2ba13748
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/olive-cobras-bow.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Add warning on startup when `vite.server.fs.strict` is disabled

4
packages/astro/src/core/dev/index.ts
View file

@ -12,7 +12,6 @@ import {
} from '../../integrations/index.js'; } from '../../integrations/index.js';
import { createVite } from '../create-vite.js'; import { createVite } from '../create-vite.js';
import { info, LogOptions, warn, warnIfUsingExperimentalSSR } from '../logger/core.js'; import { info, LogOptions, warn, warnIfUsingExperimentalSSR } from '../logger/core.js';
import { nodeLogOptions } from '../logger/node.js';
import * as msg from '../messages.js'; import * as msg from '../messages.js';
import { apply as applyPolyfill } from '../polyfill.js'; import { apply as applyPolyfill } from '../polyfill.js';
@ -65,6 +64,9 @@ export default async function dev(config: AstroConfig, options: DevOptions): Pro
if (currentVersion.includes('-')) { if (currentVersion.includes('-')) {
warn(options.logging, null, msg.prerelease({ currentVersion })); warn(options.logging, null, msg.prerelease({ currentVersion }));
} }
if (viteConfig.server?.fs?.strict === false) {
warn(options.logging, null, msg.fsStrictWarning());
}
await runHookServerStart({ config, address: devServerAddressInfo }); await runHookServerStart({ config, address: devServerAddressInfo });

4
packages/astro/src/core/messages.ts
View file

@ -145,6 +145,10 @@ export function telemetryReset() {
)}. You may be prompted again.\n`; )}. You may be prompted again.\n`;
} }
export function fsStrictWarning() {
return yellow('⚠️ Serving with vite.server.fs.strict: false. Note that all files on your machine will be accessible to anyone on your network!')
}
export function prerelease({ currentVersion }: { currentVersion: string }) { export function prerelease({ currentVersion }: { currentVersion: string }) {
const tag = currentVersion.split('-').slice(1).join('-').replace(/\..*$/, ''); const tag = currentVersion.split('-').slice(1).join('-').replace(/\..*$/, '');
const badge = bgYellow(black(` ${tag} `)); const badge = bgYellow(black(` ${tag} `));