michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Do not send body with HEAD and GET on node integration (#4105)

Browse source 
* Do not send body with HEAD and GET on node integration

* Create seven-suits-sit.md

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
This commit is contained in:
Adrian Dimitrov 2022-08-02 19:19:43 +03:00 committed by GitHub
parent 7088e86c64
commit 9cc3a11c44
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/seven-suits-sit.md Normal file
View file

@ -0,0 +1,5 @@
---
"astro": patch
---
Do not send `body` with `HEAD` or `GET` requests when using `server` output.

5
packages/astro/src/core/app/node.ts
View file

@ -11,10 +11,11 @@ function createRequestFromNodeRequest(req: IncomingMessage, body?: Uint8Array):
let url = `http://${req.headers.host}${req.url}`; let url = `http://${req.headers.host}${req.url}`;
let rawHeaders = req.headers as Record<string, any>; let rawHeaders = req.headers as Record<string, any>;
const entries = Object.entries(rawHeaders); const entries = Object.entries(rawHeaders);
const method = req.method || 'GET';
let request = new Request(url, { let request = new Request(url, {
method: req.method || 'GET', method,
headers: new Headers(entries), headers: new Headers(entries),
body, body: ['HEAD', 'GET'].includes(method) ? null : body,
}); });
if (req.socket?.remoteAddress) { if (req.socket?.remoteAddress) {
Reflect.set(request, clientAddressSymbol, req.socket.remoteAddress); Reflect.set(request, clientAddressSymbol, req.socket.remoteAddress);