michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ensure utf8 encoding when serving html (#2654)

Browse source 
* ensure utf8 encoding on servers

* Create spicy-tomatoes-act.md

* Update spicy-tomatoes-act.md

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
This commit is contained in:
Fred K. Schott 2022-02-24 12:39:41 -08:00 committed by GitHub
parent 2e5c3b5126
commit a0fc5cb5ff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/spicy-tomatoes-act.md Normal file
View file

@ -0,0 +1,5 @@
---
"astro": patch
---
Fix an issue where utf8 encoding was skipped in the dev server.

3
examples/ssr/server/server.mjs
View file

@ -18,7 +18,8 @@ async function handle(req, res) {
const html = await app.render(req, route); const html = await app.render(req, route);
res.writeHead(200, { res.writeHead(200, {
'Content-Type': 'text/html', 'Content-Type': 'text/html; charset=utf-8',
'Content-Length': Buffer.byteLength(html, 'utf-8'),
}); });
res.end(html); res.end(html);
} else if (/^\/api\//.test(req.url)) { } else if (/^\/api\//.test(req.url)) {

5
packages/astro/src/vite-plugin-astro-server/index.ts
View file

@ -3,7 +3,6 @@ import type http from 'http';
import type { AstroConfig, ManifestData, RouteData } from '../@types/astro'; import type { AstroConfig, ManifestData, RouteData } from '../@types/astro';
import { info, LogOptions } from '../core/logger.js'; import { info, LogOptions } from '../core/logger.js';
import { createRouteManifest, matchRoute } from '../core/routing/index.js'; import { createRouteManifest, matchRoute } from '../core/routing/index.js';
import mime from 'mime';
import stripAnsi from 'strip-ansi'; import stripAnsi from 'strip-ansi';
import { createSafeError } from '../core/util.js'; import { createSafeError } from '../core/util.js';
import { ssr } from '../core/render/dev/index.js'; import { ssr } from '../core/render/dev/index.js';
@ -30,8 +29,8 @@ function removeViteHttpMiddleware(server: vite.Connect.Server) {
function writeHtmlResponse(res: http.ServerResponse, statusCode: number, html: string) { function writeHtmlResponse(res: http.ServerResponse, statusCode: number, html: string) {
res.writeHead(statusCode, { res.writeHead(statusCode, {
'Content-Type': mime.getType('.html') as string, 'Content-Type': 'text/html; charset=utf-8',
'Content-Length': Buffer.byteLength(html, 'utf8'), 'Content-Length': Buffer.byteLength(html, 'utf-8'),
}); });
res.write(html); res.write(html);
res.end(); res.end();