michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

create-astro bug fixes (#5319)

Browse source 
* fix(create-astro): upgrade cli-kit

* fix(create-astro): avoid setRawMode error

* chore(lint): disable create-astro linting

Co-authored-by: Nate Moore <nate@astro.build>
This commit is contained in:
Nate Moore 2022-11-08 10:33:36 -06:00 committed by GitHub
parent 982e446e8d
commit b211eadeff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/witty-bobcats-eat.md Normal file
View file

@ -0,0 +1,5 @@
---
'create-astro': patch
---
Fix bug with `setRawMode`. Respect `--skip-houston` in all cases.

1
packages/create-astro/create-astro.mjs
View file

@ -1,4 +1,5 @@
#!/usr/bin/env node #!/usr/bin/env node
/* eslint-disable no-console */
'use strict'; 'use strict';
const currentVersion = process.versions.node; const currentVersion = process.versions.node;

2
packages/create-astro/package.json
View file

@ -29,7 +29,7 @@
"tsconfigs" "tsconfigs"
], ],
"dependencies": { "dependencies": {
"@astrojs/cli-kit": "^0.1.3", "@astrojs/cli-kit": "^0.1.4",
"chalk": "^5.0.1", "chalk": "^5.0.1",
"comment-json": "^4.2.3", "comment-json": "^4.2.3",
"execa": "^6.1.0", "execa": "^6.1.0",

6
packages/create-astro/src/index.ts
View file

@ -133,7 +133,7 @@ export async function main() {
type: 'text', type: 'text',
name: 'directory', name: 'directory',
message: 'Where would you like to create your new project?', message: 'Where would you like to create your new project?',
initial: `./${generateProjectName()}`, initial: generateProjectName(),
validate(value) { validate(value) {
if (!isValidProjectDirectory(value)) { if (!isValidProjectDirectory(value)) {
return notEmptyMsg(value); return notEmptyMsg(value);
@ -347,7 +347,9 @@ export async function main() {
const devCmd = pkgManager === 'npm' ? 'npm run dev' : `${pkgManager} dev`; const devCmd = pkgManager === 'npm' ? 'npm run dev' : `${pkgManager} dev`;
await nextSteps({ projectDir, devCmd }); await nextSteps({ projectDir, devCmd });
await say(['Good luck out there, astronaut!']); if (!args.skipHouston) {
await say(['Good luck out there, astronaut!']);
}
} }
function emojiWithFallback(char: string, fallback: string) { function emojiWithFallback(char: string, fallback: string) {

8
pnpm-lock.yaml
View file

@ -2464,7 +2464,7 @@ importers:
packages/create-astro: packages/create-astro:
specifiers: specifiers:
'@astrojs/cli-kit': ^0.1.3 '@astrojs/cli-kit': ^0.1.4
'@types/chai': ^4.3.1 '@types/chai': ^4.3.1
'@types/degit': ^2.8.3 '@types/degit': ^2.8.3
'@types/mocha': ^9.1.1 '@types/mocha': ^9.1.1
@ -2486,7 +2486,7 @@ importers:
which-pm-runs: ^1.1.0 which-pm-runs: ^1.1.0
yargs-parser: ^21.0.1 yargs-parser: ^21.0.1
dependencies: dependencies:
'@astrojs/cli-kit': 0.1.3 '@astrojs/cli-kit': 0.1.4
chalk: 5.1.2 chalk: 5.1.2
comment-json: 4.2.3 comment-json: 4.2.3
execa: 6.1.0 execa: 6.1.0
@ -3827,8 +3827,8 @@ packages:
lite-youtube-embed: 0.2.0 lite-youtube-embed: 0.2.0
dev: false dev: false
/@astrojs/cli-kit/0.1.3: /@astrojs/cli-kit/0.1.4:
resolution: {integrity: sha512-thLIdCggboKsOyYF5prn46tIpUH55Y+Y0fRN2NGD09WyxqqO5eA5aon0i4cELKTuzQrmSuu0Wl4d4xFin5OPvg==} resolution: {integrity: sha512-krtRhJr2uNdt947feVSNV9REoLupEh85g+5WRWHCKl60HhpbTRlwT962FUue26X3OeZbdoAT2pBJQmlznIIQtg==}
dependencies: dependencies:
chalk: 5.1.2 chalk: 5.1.2
log-update: 5.0.1 log-update: 5.0.1