michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Update Solid ecosystem package logic to include packages with peerDep… (#6934)

Browse source 
* Update Solid ecosystem package logic to include packages with peerDep of Solid

* Remove solid as a noExternal

* Update the changeset
This commit is contained in:
Matthew Phillips 2023-05-02 13:23:28 -04:00 committed by GitHub
parent 72c6bf01fe
commit b6797fc858
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/purple-lamps-sleep.md Normal file
View file

@ -0,0 +1,5 @@
---
"@astrojs/solid-js": patch
---
Allow Solid ecosystem packages to not need special export map configuration. By default Solid is now treated as an external package in SSR, so any other dependent packages will receive the same instance.

2
packages/integrations/solid/src/index.ts
View file

@ -47,7 +47,7 @@ async function getViteConfiguration(isDev: boolean, astroConfig: AstroConfig) {
ssr: {
target: 'node',
external: ['babel-preset-solid', ...solidPkgsConfig.ssr.external],
noExternal: ['solid-js', ...solidPkgsConfig.ssr.noExternal],
noExternal: [...solidPkgsConfig.ssr.noExternal],
},
};
}