[ci] yarn format

This commit is contained in:
matthewp 2021-06-23 20:02:44 +00:00 committed by GitHub Actions
parent e316c9578c
commit bf6aab7427
5 changed files with 10 additions and 16 deletions

View file

@ -179,9 +179,9 @@ export default function () {
Astro aims to be compatible with multiple JavaScript runtimes in the future. This includes [Deno](https://deno.land/) and [Cloudflare Workers](https://workers.cloudflare.com/) which do not support Node builtin modules such as `fs`. We encourage Astro users to write their code as cross-environment as possible. Astro aims to be compatible with multiple JavaScript runtimes in the future. This includes [Deno](https://deno.land/) and [Cloudflare Workers](https://workers.cloudflare.com/) which do not support Node builtin modules such as `fs`. We encourage Astro users to write their code as cross-environment as possible.
Due to that, you cannot use Node modules that you're familiar with such as `fs` and `path`. Our aim is to provide alternative built in to Astro. If you're use case is not covered please let us know. Due to that, you cannot use Node modules that you're familiar with such as `fs` and `path`. Our aim is to provide alternative built in to Astro. If you're use case is not covered please let us know.
However, if you *really* need to use these builtin modules we don't want to stop you. Node supports the `node:` prefix for importing builtins, and this is also supported by Astro. If you want to read a file, for example, you can do so like this: However, if you _really_ need to use these builtin modules we don't want to stop you. Node supports the `node:` prefix for importing builtins, and this is also supported by Astro. If you want to read a file, for example, you can do so like this:
```jsx ```jsx
--- ---
@ -192,4 +192,5 @@ const json = await fs.readFile(url, 'utf-8');
const data = JSON.parse(json); const data = JSON.parse(json);
--- ---
<span>Version: {data.version}</span> <span>Version: {data.version}</span>
```

View file

@ -328,7 +328,7 @@ function compileModule(module: Script, state: CodegenState, compileOptions: Comp
for (const componentImport of componentImports) { for (const componentImport of componentImports) {
const importUrl = componentImport.source.value; const importUrl = componentImport.source.value;
if(nodeBuiltinsSet.has(importUrl)) { if (nodeBuiltinsSet.has(importUrl)) {
throw new Error(`Node builtins must be prefixed with 'node:'. Use node:${importUrl} instead.`); throw new Error(`Node builtins must be prefixed with 'node:'. Use node:${importUrl} instead.`);
} }
for (const specifier of componentImport.specifiers) { for (const specifier of componentImport.specifiers) {

View file

@ -18,13 +18,7 @@ const isAstroRenderer = (name: string) => {
// These packages should NOT be built by `esinstall` // These packages should NOT be built by `esinstall`
// But might not be explicit dependencies of `astro` // But might not be explicit dependencies of `astro`
const denyList = [ const denyList = ['prismjs/components/index.js', '@vue/server-renderer', '@astrojs/markdown-support', 'node:fs/promises', ...nodeBuiltinsMap.values()];
'prismjs/components/index.js',
'@vue/server-renderer',
'@astrojs/markdown-support',
'node:fs/promises',
...nodeBuiltinsMap.values()
];
export default Object.keys(pkg.dependencies) export default Object.keys(pkg.dependencies)
// Filter out packages that should be loaded threw Snowpack // Filter out packages that should be loaded threw Snowpack

View file

@ -1,5 +1,4 @@
import { builtinModules } from 'module';
import {builtinModules} from 'module';
export const nodeBuiltinsSet = new Set(builtinModules); export const nodeBuiltinsSet = new Set(builtinModules);
export const nodeBuiltinsMap = new Map(builtinModules.map(bareName => [bareName, 'node:' + bareName])); export const nodeBuiltinsMap = new Map(builtinModules.map((bareName) => [bareName, 'node:' + bareName]));

View file

@ -391,8 +391,8 @@ async function createSnowpack(astroConfig: AstroConfig, options: CreateSnowpackO
external: snowpackExternals, external: snowpackExternals,
}, },
alias: { alias: {
...Object.fromEntries(nodeBuiltinsMap) ...Object.fromEntries(nodeBuiltinsMap),
} },
}); });
snowpack = await startSnowpackServer( snowpack = await startSnowpackServer(