michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix types for TableHTMLAttributes (#6197)

Browse source 
* Fix types for TableHTMLAttributes

- Add 'string' type to 'border' attribute
- Add 'false | true' to 'frame' attribute

Thanks Princesseuh for helping

* Create sixty-scissors-refuse.md

* Make changeset more descriptive

* Fix previous changset

---------

Co-authored-by: BryceRussell <19967622+BryceRussell@users.noreply.github.com>
This commit is contained in:
Bryce Russell 2023-02-09 13:12:15 -06:00 committed by GitHub
parent 11e1fa9883
commit c75d319ee6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.changeset/sixty-scissors-refuse.md Normal file
View file

@ -0,0 +1,6 @@
---
'astro': patch
---
Fix `border` and `frame` attribute types on `TableHTMLAttributes` interface

4
packages/astro/astro-jsx.d.ts vendored
View file

@ -936,10 +936,10 @@ declare namespace astroHTML.JSX {
interface TableHTMLAttributes extends HTMLAttributes { interface TableHTMLAttributes extends HTMLAttributes {
align?: 'left' | 'center' | 'right' | undefined | null; align?: 'left' | 'center' | 'right' | undefined | null;
bgcolor?: string | undefined | null; bgcolor?: string | undefined | null;
border?: number | undefined | null; border?: string | number | undefined | null;
cellpadding?: number | string | undefined | null; cellpadding?: number | string | undefined | null;
cellspacing?: number | string | undefined | null; cellspacing?: number | string | undefined | null;
frame?: boolean | undefined | null; frame?: boolean | 'false' | 'true' | undefined | null;
rules?: 'none' | 'groups' | 'rows' | 'columns' | 'all' | undefined | null; rules?: 'none' | 'groups' | 'rows' | 'columns' | 'all' | undefined | null;
summary?: string | undefined | null; summary?: string | undefined | null;
width?: number | string | undefined | null; width?: number | string | undefined | null;