fix getDataEntryById to lookup by base name (#8645)

.changeset/spicy-walls-wave.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix getDataEntryById to lookup by basename

packages/astro/content-module.template.mjs

@@ -70,7 +70,7 @@ export const getEntryBySlug = createGetEntryBySlug({
 });
 
 export const getDataEntryById = createGetDataEntryById({
-	dataCollectionToEntryMap,
+	getEntryImport: createGlobLookup(dataCollectionToEntryMap),
 });
 
 export const getEntry = createGetEntry({

packages/astro/src/content/runtime.ts

@@ -139,13 +139,12 @@ export function createGetEntryBySlug({
 }
 
 export function createGetDataEntryById({
-	dataCollectionToEntryMap,
+	getEntryImport,
 }: {
-	dataCollectionToEntryMap: CollectionToEntryMap;
+	getEntryImport: GetEntryImport;
 }) {
 	return async function getDataEntryById(collection: string, id: string) {
-		const lazyImport =
-			dataCollectionToEntryMap[collection]?.[/*TODO: filePathToIdMap*/ id + '.json'];
+		const lazyImport = await getEntryImport(collection, id);
 
 		// TODO: AstroError
 		if (!lazyImport) throw new Error(`Entry ${collection} → ${id} was not found.`);

packages/astro/test/data-collections.test.js

@@ -41,6 +41,17 @@ describe('Content Collections - data collections', () => {
 		});
 	});
 
+	describe('getDataEntryById', () => {
+		let json;
+		before(async () => {
+			const rawJson = await fixture.readFile('/translations/by-id.json');
+			json = JSON.parse(rawJson);
+		});
+		it('Grabs the item by the base file name', () => {
+			expect(json.id).to.equal('en');
+		});
+	});
+
 	describe('Authors Entry', () => {
 		for (const authorId of authorIds) {
 			let json;

packages/astro/test/fixtures/data-collections/src/pages/translations/by-id.json.js

@@ -0,0 +1,9 @@
+import { getDataEntryById } from 'astro:content';
+
+export async function GET() {
+	const item = await getDataEntryById('i18n', 'en');
+
+	return {
+		body: JSON.stringify(item),
+	}
+}