michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: clarify analyzer comments

Browse source
This commit is contained in:
bholmesdev 2023-01-30 15:11:45 -05:00
parent 0577e4e9e4
commit d556df728d
1 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/astro/src/core/build/vite-plugin-analyzer.ts
View file

@ -89,22 +89,13 @@ export function vitePluginAnalyzer(internals: BuildInternals): VitePlugin {
} }
internals.discoveredScripts.add(moduleId); internals.discoveredScripts.add(moduleId);
// TODO: map raw URL (?type=script) to client build ready URL
// This will inject the raw URL as a script tag as-is,
// which will fail to map with the client build output.
pageData.propagatedScripts = propagatedMapByImporter; pageData.propagatedScripts = propagatedMapByImporter;
// Add propagated scripts to client build, // Add propagated scripts to client build,
// but DON'T add to pages -> hoisted script map. // but DON'T add to pages -> hoisted script map.
// const flattenedPropagatedScripts = Array.from(propagatedMapByImporter.values())
// .map((s) => Array.from(s))
// .flat();
// const uniquePropagatedId = JSON.stringify(flattenedPropagatedScripts.sort());
// if (uniqueHoistedIds.has(uniquePropagatedId)) {
// moduleId = uniqueHoistedIds.get(uniquePropagatedId)!;
// } else {
// // Otherwise, create a unique id for this set of hoisted scripts
// moduleId = `/astro/hoisted.js?q=${uniqueHoistedIds.size}`;
// console.log('uniquePropagatedId', uniquePropagatedId, moduleId);
// uniqueHoistedIds.set(uniquePropagatedId, moduleId);
// }
for (const propagatedScripts of propagatedMapByImporter.values()) { for (const propagatedScripts of propagatedMapByImporter.values()) {
for (const propagatedScript of propagatedScripts) { for (const propagatedScript of propagatedScripts) {
internals.discoveredScripts.add(propagatedScript); internals.discoveredScripts.add(propagatedScript);