michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Handle flaky tests (#7651)

Browse source
This commit is contained in:
Bjorn Lu 2023-07-17 20:30:02 +08:00 committed by GitHub
parent 16af1709a5
commit d69fe3a8d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 56 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/astro/package.json
View file

@ -107,8 +107,8 @@
"postbuild": "astro-scripts copy \"src/**/*.astro\" && astro-scripts copy \"src/**/*.wasm\"",
"test:unit": "mocha --exit --timeout 30000 ./test/units/**/*.test.js",
"test:unit:match": "mocha --exit --timeout 30000 ./test/units/**/*.test.js -g",
"test": "pnpm run test:unit && mocha --exit --timeout 20000 --ignore **/lit-element.test.js && mocha --timeout 20000 **/lit-element.test.js",
"test:match": "mocha --timeout 20000 -g",
"test": "pnpm run test:unit && mocha --exit --timeout 30000 --ignore **/lit-element.test.js && mocha --timeout 30000 **/lit-element.test.js",
"test:match": "mocha --timeout 30000 -g",
"test:e2e": "playwright test",
"test:e2e:match": "playwright test -g"
},

6
packages/astro/test/astro-get-static-paths.test.js
View file

@ -54,7 +54,11 @@ describe('getStaticPaths - dev calls', () => {
await devServer.stop();
});
it('only calls getStaticPaths once', async () => {
it('only calls getStaticPaths once', async function () {
// Sometimes this fail in CI as the chokidar watcher triggers an update and invalidates the route cache,
// causing getStaticPaths to be called twice. Workaround this with 2 retries for now.
this.retries(2);
let res = await fixture.fetch('/a');
expect(res.status).to.equal(200);

29
packages/integrations/cloudflare/test/basics.test.js
View file

@ -5,28 +5,29 @@ import * as cheerio from 'cheerio';
describe.skip('Basic app', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
/** @type {import('./test-utils').WranglerCLI} */
let cli;
before(async () => {
fixture = await loadFixture({
root: './fixtures/basics/',
});
await fixture.build();
cli = runCLI('./fixtures/basics/', { silent: true, port: 8789 });
await cli.ready;
});
after(async () => {
await cli.stop();
});
it('can render', async () => {
const { ready, stop } = runCLI('./fixtures/basics/', { silent: true, port: 8789 });
try {
await ready;
let res = await fetch(`http://localhost:8789/`);
expect(res.status).to.equal(200);
let html = await res.text();
let $ = cheerio.load(html);
expect($('h1').text()).to.equal('Testing');
expect($('#env').text()).to.equal('secret');
} finally {
await stop();
}
let res = await fetch(`http://localhost:8789/`);
expect(res.status).to.equal(200);
let html = await res.text();
let $ = cheerio.load(html);
expect($('h1').text()).to.equal('Testing');
expect($('#env').text()).to.equal('secret');
});
});

30
packages/integrations/cloudflare/test/cf.test.js
View file

@ -6,6 +6,8 @@ import cloudflare from '../dist/index.js';
describe('Cf metadata and caches', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
/** @type {import('./test-utils').WranglerCLI} */
let cli;
before(async () => {
fixture = await loadFixture({
@ -14,22 +16,22 @@ describe('Cf metadata and caches', () => {
adapter: cloudflare(),
});
await fixture.build();
cli = runCLI('./fixtures/cf/', { silent: true, port: 8788 });
await cli.ready;
});
after(async () => {
await cli.stop();
});
it('Load cf and caches API', async () => {
const { ready, stop } = runCLI('./fixtures/cf/', { silent: true, port: 8788 });
try {
await ready;
let res = await fetch(`http://localhost:8788/`);
expect(res.status).to.equal(200);
let html = await res.text();
let $ = cheerio.load(html);
// console.log($('#cf').text(), html);
expect($('#cf').text()).to.contain('city');
expect($('#hasCache').text()).to.equal('true');
} finally {
await stop();
}
let res = await fetch(`http://localhost:8788/`);
expect(res.status).to.equal(200);
let html = await res.text();
let $ = cheerio.load(html);
// console.log($('#cf').text(), html);
expect($('#cf').text()).to.contain('city');
expect($('#hasCache').text()).to.equal('true');
});
});

4
packages/integrations/cloudflare/test/test-utils.js
View file

@ -5,6 +5,7 @@ import { fileURLToPath } from 'url';
export { fixLineEndings } from '../../../astro/test/test-utils.js';
/**
* @typedef {{ ready: Promise<void>, stop: Promise<void> }} WranglerCLI
* @typedef {import('../../../astro/test/test-utils').Fixture} Fixture
*/
@ -19,6 +20,9 @@ const wranglerPath = fileURLToPath(
new URL('../node_modules/wrangler/bin/wrangler.js', import.meta.url)
);
/**
* @returns {WranglerCLI}
*/
export function runCLI(basePath, { silent, port = 8787 }) {
const script = fileURLToPath(new URL(`${basePath}/dist/_worker.js`, import.meta.url));
const p = spawn('node', [wranglerPath, 'dev', '-l', script, '--port', port]);

27
packages/integrations/cloudflare/test/with-solid-js.test.js
View file

@ -5,27 +5,28 @@ import * as cheerio from 'cheerio';
describe('With SolidJS', () => {
/** @type {import('./test-utils').Fixture} */
let fixture;
/** @type {import('./test-utils').WranglerCLI} */
let cli;
before(async () => {
fixture = await loadFixture({
root: './fixtures/with-solid-js/',
});
await fixture.build();
cli = runCLI('./fixtures/with-solid-js/', { silent: true, port: 8790 });
await cli.ready;
});
after(async () => {
await cli.stop();
});
it('renders the solid component', async () => {
const { ready, stop } = runCLI('./fixtures/with-solid-js/', { silent: true, port: 8790 });
try {
await ready;
let res = await fetch(`http://localhost:8790/`);
expect(res.status).to.equal(200);
let html = await res.text();
let $ = cheerio.load(html);
expect($('.solid').text()).to.equal('Solid Content');
} finally {
await stop();
}
let res = await fetch(`http://localhost:8790/`);
expect(res.status).to.equal(200);
let html = await res.text();
let $ = cheerio.load(html);
expect($('.solid').text()).to.equal('Solid Content');
});
});