michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix sitemap filter (#7263)

Browse source
This commit is contained in:
André Alves 2023-06-02 05:07:44 -03:00 committed by GitHub
parent 408be72d1d
commit dff0d0dda2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 54 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/eight-planes-drop.md Normal file
View file

@ -0,0 +1,5 @@
---
'@astrojs/sitemap': patch
---
Fix sitemap does not filter pages

4
packages/integrations/sitemap/src/index.ts
View file

@ -118,6 +118,8 @@ const createPlugin = (options?: SitemapOptions): AstroIntegration => {
return urls;
}, []);
pageUrls = Array.from(new Set([...pageUrls, ...routeUrls, ...(customPages ?? [])]));
try {
if (filter) {
pageUrls = pageUrls.filter(filter);
@ -127,8 +129,6 @@ const createPlugin = (options?: SitemapOptions): AstroIntegration => {
return;
}
pageUrls = Array.from(new Set([...pageUrls, ...routeUrls, ...(customPages ?? [])]));
if (pageUrls.length === 0) {
logger.warn(`No pages found!\n\`${OUTFILE}\` not created.`);
return;

46
packages/integrations/sitemap/test/filter.test.js Normal file
View file

@ -0,0 +1,46 @@
import { loadFixture, readXML } from './test-utils.js';
import { expect } from 'chai';
import { sitemap } from './fixtures/static/deps.mjs';
describe('Filter support', () => {
/** @type {import('./test-utils.js').Fixture} */
let fixture;
describe('Static', () => {
before(async () => {
fixture = await loadFixture({
root: './fixtures/static/',
integrations: [sitemap({
filter: (page) => page !== 'http://example.com/two/'
})],
});
await fixture.build();
});
it('Just one page is added', async () => {
const data = await readXML(fixture.readFile('/sitemap-0.xml'));
const urls = data.urlset.url;
expect(urls.length).to.equal(1);
});
});
describe('SSR', () => {
before(async () => {
fixture = await loadFixture({
root: './fixtures/ssr/',
integrations: [sitemap({
filter: (page) => page !== 'http://example.com/two/'
})],
});
await fixture.build();
});
it('Just one page is added', async () => {
const data = await readXML(fixture.readFile('/client/sitemap-0.xml'));
const urls = data.urlset.url;
expect(urls.length).to.equal(1);
});
});
});

1
packages/integrations/sitemap/test/fixtures/static/deps.mjs vendored Normal file
View file

@ -0,0 +1 @@
export { default as sitemap } from '@astrojs/sitemap';