michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[@astrojs/image] Handle missing trailing slash in processStaticImage (#6421)

Browse source 
The code path changed by this commit isn't only taken when running using Vite. If the site is configured with a base url which is different from `/` but does **not** end with `/` (for example, because `trailingSlash` is set to `never`), the `- 1` results in an off-by-one error when truncating the URL.

By checking if the base url ends with `/`, we can determine the right length for the prefix to truncate.
This commit is contained in:
Vincent Tavernier 2023-03-07 19:00:34 +01:00 committed by GitHub
parent fbab73c96e
commit e58a92527f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/eleven-mugs-flash.md Normal file
View file

@ -0,0 +1,5 @@
---
'@astrojs/image': patch
---
Handle missing trailing slash in processStaticImage

2
packages/integrations/image/src/build/ssg.ts
View file

@ -138,7 +138,7 @@ export async function ssgBuild({
// Vite will prefix a hashed image with the base path, we need to strip this
// off to find the actual file relative to /dist
if (config.base && src.startsWith(config.base)) {
src = src.substring(config.base.length - 1);
src = src.substring(config.base.length - +config.base.endsWith('/'));
}
if (isRemoteImage(src)) {