michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixes bug where Astro can't distinguish between two equal components differing only by props when hydrating (#846)

Browse source
This commit is contained in:
Mats 2021-07-27 14:52:17 +02:00 • committed by GitHub
parent bef5103ae3
commit e89a99f342
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/chilly-gorillas-wash.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
This includes the props passed to a hydration component when generating the hash/id. This prevents multiple instances of the same component with differing props to be treated as the same component when hydrated by Astro.

3
packages/astro/src/internal/__astro_component.ts
View file

@ -187,7 +187,8 @@ export function __astro_component(Component: any, metadata: AstroComponentMetada
} }
// If we ARE hydrating this component, let's generate the hydration script // If we ARE hydrating this component, let's generate the hydration script
const astroId = hash.unique(html); const stringifiedProps = JSON.stringify(props);
const astroId = hash.unique(html + stringifiedProps);
const script = await generateHydrateScript({ instance, astroId, props }, metadata as Required<AstroComponentMetadata>); const script = await generateHydrateScript({ instance, astroId, props }, metadata as Required<AstroComponentMetadata>);
const astroRoot = `<astro-root uid="${astroId}">${html}</astro-root>`; const astroRoot = `<astro-root uid="${astroId}">${html}</astro-root>`;
return [astroRoot, script].join('\n'); return [astroRoot, script].join('\n');