michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix ESLint not working in CI (#4837)

Browse source 
* Update ESLint extensions

* Use fredkbot

* Only use fredkbot for the commit

* Disable autofix

* Fix lint error
This commit is contained in:
Erika 2022-09-22 12:37:41 -03:00 committed by GitHub
parent 47d4165603
commit e9eb4d1f3d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
.github/workflows/ci.yml vendored
View file

@ -55,15 +55,16 @@ jobs:
# Otherwise, run lint autofixer # Otherwise, run lint autofixer
- name: Lint - name: Lint
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == github.repository_owner }} if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == github.repository_owner }}
uses: wearerequired/lint-action@v1.11.1 uses: wearerequired/lint-action@v2.1.0
env: env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with: with:
eslint: true eslint: true
eslint_extensions: js,ts,cts,mts,cjs,mjs
prettier: false prettier: false
auto_fix: true auto_fix: false
git_name: github-actions[bot] git_name: fredkbot
git_email: github-actions[bot]@users.noreply.github.com git_email: fred+astrobot@astro.build
commit_message: 'chore(lint): ${linter} fix' commit_message: 'chore(lint): ${linter} fix'
github_token: ${{ secrets.GITHUB_TOKEN }} github_token: ${{ secrets.GITHUB_TOKEN }}
neutral_check_on_warning: true neutral_check_on_warning: true
@ -97,7 +98,7 @@ jobs:
- name: Install dependencies - name: Install dependencies
run: pnpm install run: pnpm install
- name: Build Packages - name: Build Packages
run: pnpm run build run: pnpm run build
@ -213,4 +214,4 @@ jobs:
run: pnpm run build run: pnpm run build
- name: Test - name: Test
run: pnpm run test:smoke run: pnpm run test:smoke

8
packages/astro/src/core/messages.ts
View file

@ -134,12 +134,12 @@ export function resolveServerUrls({
networkInterface?.address && networkInterface?.address &&
networkInterface?.family === (nodeVersion < 18 || nodeVersion >= 18.4 ? 'IPv4' : 4) networkInterface?.family === (nodeVersion < 18 || nodeVersion >= 18.4 ? 'IPv4' : 4)
); );
for (let { address } of ipv4Networks) { for (let { address: ipv4Address } of ipv4Networks) {
if (address.includes('127.0.0.1')) { if (ipv4Address.includes('127.0.0.1')) {
const displayAddress = address.replace('127.0.0.1', localAddress); const displayAddress = ipv4Address.replace('127.0.0.1', localAddress);
local = toDisplayUrl(displayAddress); local = toDisplayUrl(displayAddress);
} else { } else {
network = toDisplayUrl(address); network = toDisplayUrl(ipv4Address);
} }
} }
} }