michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: Can't overwrite vite's MODE environment variable (#4850)

Browse source 
* Add flags to the build options

* replace mode: 'production' as fallback

* Update mode support

* Add changeset
This commit is contained in:
Rishi Raj Jain 2022-09-23 17:38:57 +05:30 committed by GitHub
parent ee5fdeffdd
commit edb7bead6e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/short-ravens-marry.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
add support for changing mode via CLI

2
packages/astro/src/cli/index.ts
View file

@ -239,7 +239,7 @@ async function runCommand(cmd: string, flags: yargs.Arguments) {
} }
case 'build': { case 'build': {
return await build(settings, { logging, telemetry }); return await build(settings, { ...flags, logging, telemetry });
} }
case 'check': { case 'check': {

4
packages/astro/src/core/build/static-build.ts
View file

@ -115,8 +115,8 @@ async function ssrBuild(opts: StaticBuildOptions, internals: BuildInternals, inp
const viteBuildConfig: ViteConfigWithSSR = { const viteBuildConfig: ViteConfigWithSSR = {
...viteConfig, ...viteConfig,
mode: viteConfig.mode || 'production',
logLevel: opts.viteConfig.logLevel ?? 'error', logLevel: opts.viteConfig.logLevel ?? 'error',
mode: 'production',
build: { build: {
target: 'esnext', target: 'esnext',
...viteConfig.build, ...viteConfig.build,
@ -193,8 +193,8 @@ async function clientBuild(
const viteBuildConfig = { const viteBuildConfig = {
...viteConfig, ...viteConfig,
mode: viteConfig.mode || 'production',
logLevel: 'info', logLevel: 'info',
mode: 'production',
build: { build: {
target: 'esnext', target: 'esnext',
...viteConfig.build, ...viteConfig.build,