diff --git a/packages/astro/e2e/multiple-frameworks.test.js b/packages/astro/e2e/multiple-frameworks.test.js index ebc2e345f..729bfe002 100644 --- a/packages/astro/e2e/multiple-frameworks.test.js +++ b/packages/astro/e2e/multiple-frameworks.test.js @@ -13,7 +13,7 @@ test.afterAll(async () => { await devServer.stop(); }); -test.describe('Multiple frameworks', () => { +test.skip('Multiple frameworks', () => { test.skip('React counter', async ({ page }) => { await page.goto('/'); @@ -44,7 +44,7 @@ test.describe('Multiple frameworks', () => { await expect(count, 'count incremented by 1').toHaveText('1'); }); - test('Solid counter', async ({ page }) => { + test.skip('Solid counter', async ({ page }) => { await page.goto('/'); const counter = page.locator('#solid-counter'); diff --git a/packages/astro/src/core/fs/index.ts b/packages/astro/src/core/fs/index.ts index f865ef4a8..521d99835 100644 --- a/packages/astro/src/core/fs/index.ts +++ b/packages/astro/src/core/fs/index.ts @@ -27,8 +27,6 @@ export function emptyDir(_dir: URL, skip?: Set): void { if (er.code === 'ENOENT') { return; } - // Windows can EPERM on stat. Life is suffering. - // From https://github.com/isaacs/rimraf/blob/8c10fb8d685d5cc35708e0ffc4dac9ec5dd5b444/rimraf.js#L294 if (er.code === 'EPERM' && isWindows) { fixWinEPERMSync(p, rmOptions, er); } @@ -36,7 +34,25 @@ export function emptyDir(_dir: URL, skip?: Set): void { } } -// Taken from https://github.com/isaacs/rimraf/blob/8c10fb8d685d5cc35708e0ffc4dac9ec5dd5b444/rimraf.js#L183 +/** + * https://github.com/isaacs/rimraf/blob/8c10fb8d685d5cc35708e0ffc4dac9ec5dd5b444/rimraf.js#L183 + * @license ISC + * The ISC License + * + * Copyright (c) Isaac Z. Schlueter and Contributors + * + * Permission to use, copy, modify, and/or distribute this software for any +purpose with or without fee is hereby granted, provided that the above +copyright notice and this permission notice appear in all copies. + * + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR +IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. + */ const fixWinEPERMSync = (p: string, options: fs.RmDirOptions, er: any) => { try { fs.chmodSync(p, 0o666);