michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert "Removes trailing dash from generated slugs in markdown (#3044)"

Browse source 
This reverts commit 8530cce14f.
This commit is contained in:
Fred K. Schott 2022-07-18 14:32:51 -07:00
parent 4555c8cb0b
commit f5c9d8e829
3 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/cold-bears-sneeze.md
View file

@ -1,5 +0,0 @@
---
'@astrojs/markdown-remark': minor
---
fixed generated slugs in markdown that ends with a dash

6
packages/markdown/remark/src/rehype-collect-headers.ts
View file

@ -53,11 +53,7 @@ export default function createCollectHeaders() {
node as any
).value = `<${node.tagName} id={${node.properties.id}}>${raw}</${node.tagName}>`;
} else {
let slug = slugger.slug(text);
if (slug.endsWith('-')) slug = slug.slice(0, -1);
node.properties.id = slug;
node.properties.id = slugger.slug(text);
}
}

2
packages/markdown/remark/test/expressions.test.js
View file

@ -54,7 +54,7 @@ describe('expressions', () => {
chai
.expect(code)
.to.equal(
'<h1 id="-foo--is-a-shorthand-for--foo-foo"><code is:raw>{ foo }</code> is a shorthand for <code is:raw>{ foo: foo }</code></h1>'
'<h1 id="-foo--is-a-shorthand-for--foo-foo-"><code is:raw>{ foo }</code> is a shorthand for <code is:raw>{ foo: foo }</code></h1>'
);
});