michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Allow search params (#1927)

Browse source 
Fixes #1795
This commit is contained in:
Drew Powers 2021-11-19 12:57:24 -07:00 committed by GitHub
parent 1692675575
commit f7b23d5cf1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/astro/src/core/dev/index.ts
View file

@ -110,7 +110,7 @@ export class AstroDevServer {
} }
const route = this.mostRecentRoute; const route = this.mostRecentRoute;
const pathname = route?.pathname ?? '/'; const [pathname, search = undefined] = (route?.pathname ?? '/').split('?');
if (!route) { if (!route) {
viteServer.ws.send({ viteServer.ws.send({
@ -274,7 +274,7 @@ export class AstroDevServer {
private async handleRequest(req: http.IncomingMessage, res: http.ServerResponse, next: NextFunction) { private async handleRequest(req: http.IncomingMessage, res: http.ServerResponse, next: NextFunction) {
if (!this.viteServer) throw new Error(`AstroDevServer.start() not called`); if (!this.viteServer) throw new Error(`AstroDevServer.start() not called`);
let pathname = req.url || '/'; // original request let [pathname, search = undefined] = (req.url || '/').split('?'); // original request
const reqStart = performance.now(); const reqStart = performance.now();
let filePath: URL | undefined; let filePath: URL | undefined;
try { try {

5
packages/astro/test/dev-routing.test.js
View file

@ -23,6 +23,11 @@ describe('Development Routing', () => {
expect(response.status).to.equal(200); expect(response.status).to.equal(200);
}); });
it('200 when adding search params', async () => {
const response = await fixture.fetch('/?foo=bar');
expect(response.status).to.equal(200);
});
it('200 when loading non-root page', async () => { it('200 when loading non-root page', async () => {
const response = await fixture.fetch('/another'); const response = await fixture.fetch('/another');
expect(response.status).to.equal(200); expect(response.status).to.equal(200);