michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert "Fix race condition when performing swap for fallback"

Browse source 
This reverts commit e5f7d11ef5.
This commit is contained in:
Matthew Phillips 2023-08-03 19:57:36 -04:00
parent e5f7d11ef5
commit fa4367792b
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/astro/components/ViewTransitions.astro
View file

@ -168,18 +168,13 @@ const { fallback = 'animate' } = Astro.props as Props;
// Trigger the animations // Trigger the animations
document.documentElement.dataset.astroTransitionFallback = 'old'; document.documentElement.dataset.astroTransitionFallback = 'old';
const fallbackSwap = () => { doc.documentElement.dataset.astroTransitionFallback = 'new';
removeEventListener('animationend', fallbackSwap);
clearTimeout(timeout);
swap();
document.documentElement.dataset.astroTransitionFallback = 'new';
};
// If there are any animations, want for the animationend event. // If there are any animations, want for the animationend event.
addEventListener('animationend', fallbackSwap, { once: true }); addEventListener('animationend', swap, { once: true });
// If there are no animations, go ahead and swap on next tick // If there are no animations, go ahead and swap on next tick
// This is necessary because we do not know if there are animations. // This is necessary because we do not know if there are animations.
// The setTimeout is a fallback in case there are none. // The setTimeout is a fallback in case there are none.
var timeout = setTimeout(() => !isAnimating && fallbackSwap()); setTimeout(() => !isAnimating && swap());
} else { } else {
swap(); swap();
} }