michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
6474 commits 322 branches 1612 tags 320 MiB
Commit graph

2718 commits

Author SHA1 Message Date
Houston (Bot)
ee06c4fe5c
[ci] release (#8172) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-23 22:12:09 +08:00
Bjorn Lu
cb95aa5f8e
Update rss package to return a response (#8198) 2023-08-23 21:09:11 +08:00
Bjorn Lu
273335cb01
Fix Astro components parent-child render order (#8187) 2023-08-23 20:29:34 +08:00
Bjorn Lu
632579dc20
Prevent bundling sharp (#8196) 2023-08-23 17:52:53 +08:00
Martin Trapp
9142178b11
Mt scroll behavior (#8184) 
* The scrolling behavior of ViewTransition is now more similar to the expected browser behavior

* format

* removed browser detection
 2023-08-22 13:33:49 -04:00
Martin Trapp
fddd4dc71a
Fixes in the client-side router (#8166) 
* Fixes in the client-side router

* reverted function declaration after review (#8166)

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-22 12:59:17 -04:00
Martin Trapp
cfc465ddeb
fix: self link does not trigger page reload (#8182) 2023-08-22 11:17:30 -04:00
Houston (Bot)
9f1881455a
[ci] release (rc) (#8147) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-22 10:19:18 -04:00
bluwy
a93e061cfb Fix turbolink changeset 2023-08-22 21:03:40 +08:00
Emanuele Stoppa
2d50d50b6a Merge remote-tracking branch 'origin/main' into next 2023-08-22 14:02:15 +01:00
André Alves
5821323285
add: config error if outDir is inside publicDir (#8152) 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-22 11:17:47 +01:00
Bjorn Lu
732111cdce
Deprecate drafts feature (#8099) 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-22 16:11:59 +08:00
Chris Swithinbank
179796405e
Use more permissive type for defineCollection schema option (#8163) 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-21 19:48:50 +02:00
Emanuele Stoppa
f003e73643
feat: style scoped hash is lowercase (#8180) 2023-08-21 13:43:48 -04:00
Matthew Phillips
6011d52d38
RC Release candidate (#8179) 
* RC Release candidate

* Use the rc tag
 2023-08-21 13:11:26 -04:00
Emanuele Stoppa
d08c83ee3f
fix(@astrojs/node): handler should work with express (#8176) 2023-08-21 17:29:38 +01:00
Emanuele Stoppa
d43ca69c1d Merge remote-tracking branch 'origin/main' into next 2023-08-21 14:21:53 +01:00
Nate Moore
adf9fccfdd Stringify shouldn't throw on user object during rendering (#8127) 
* fix(#7923): do not throw on user { type } object

* chore: remove unused type export

* chore: guess it wasn't unused
 2023-08-21 14:17:04 +01:00
Nate Moore
2ae9d37f0a fix(dev): open to base path (#8123) 2023-08-21 14:17:04 +01:00
Nate Moore
42785c7b78 fix(#6965): fix build stats (#8122) 2023-08-21 14:17:03 +01:00
Martin Trapp
33b8910cfd only update our own history entires during back navigation through view transitions (#8116) 2023-08-21 14:16:36 +01:00
Martin Trapp
a87cbe4003 fix: reinsert attribute to specify direction of ViewTransition (forward / back) (#8109) 2023-08-21 14:16:36 +01:00
Bjorn Lu
be6bbd2c86
Remove deprecated APIs (#8170) 2023-08-21 21:04:15 +08:00
Bjorn Lu
e79e3779df
Remove pre-shiki v0.14 theme names (#8169) 2023-08-21 21:02:30 +08:00
Erika
95120efbe8
fix(assets): Add missing type for imageConfig export (#8171) 2023-08-21 12:35:49 +02:00
Bjorn Lu
767eb68666
Deprecate simple objects from endpoints (#8132) 2023-08-21 13:55:56 +08:00
Houston (Bot)
34c39a0c96
[ci] release (#8145) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-18 17:13:25 -04:00
Matthew Phillips
531cc3e490
Fix missing package file regression (#8149) 2023-08-18 17:08:18 -04:00
Arsh
4c15c06969
fix(node): delegate preview's not found and error handling to core/app (#8141) 
* fix(node): delegate preview's not found and error handling to core/app

* add changeset

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-18 15:51:46 -05:00
Nate Moore
81545197a3
Replace class:list implementation with clsx (#8142) 
* chore: replace `class:list` implementation with `clsx`

* chore: remove Set support from `class:list` test

* chore: better class:list test

* Update packages/astro/src/runtime/server/render/component.ts
 2023-08-18 15:25:57 -05:00
Arsh
04caa99c48
fix(data collections): normalize file paths for DataEntry.id (#8144) 
* normalize file paths for DataEntry.id

* add changeset
 2023-08-18 15:42:53 -04:00
Houston (Bot)
5e6bd6ab5d
[ci] release (beta) (#8140) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-18 18:49:34 +02:00
Erika
db39206cbb
fix: polyfill File using undici instead of node:buffer (#8139) 
* fix: polyfill File using undici instead of node:buffer

* chore: changeset
 2023-08-18 18:23:51 +02:00
Houston (Bot)
e5c13881f1
[ci] release (beta) (#8073) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-18 11:46:47 -04:00
Houston (Bot)
e3c030e5d3
[ci] release (#8138) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-18 10:36:25 -05:00
André Alves
97c8760d78
Fix 404 response leading to an infinite loop when there is no 404 page (#8136) 
* fix: 404 response leads to infinite loop

* chore: changeset

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-18 10:27:44 -05:00
Nate Moore
8c0a4ed106
fix(react): add missing export (#8137) 2023-08-18 10:26:07 -05:00
Houston (Bot)
5c190d06f1
[ci] release (#8096) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-18 10:31:52 -04:00
Arsh
f50d02c201
changeset(next): inlineStylesheets default switch is major (#8133) 2023-08-18 14:56:21 +01:00
Erika
3e834293d4
feat: add polyfills for stackblitz (#8130) 
* feat: add polyfills for Stackblitz

* chore: changeset
 2023-08-18 15:13:35 +02:00
Matthew Phillips
43140b87ab
Add missing mdx changeset (#8131) 2023-08-18 09:03:56 -04:00
Erika
c2c71d90c2
fix: better error when Sharp can't be resolved (ex: pnpm) (#8128) 
* fix: better error when Sharp can't be resolved (ex: pnpm)

* chore: changeset

* Apply suggestions from code review

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-18 15:02:55 +02:00
Nate Moore
b12c8471f4
Stringify shouldn't throw on user object during rendering (#8127) 
* fix(#7923): do not throw on user { type } object

* chore: remove unused type export

* chore: guess it wasn't unused
 2023-08-18 07:26:52 -05:00
Bjorn Lu
dbc97b121f
Export experimental JS API (#7979) 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-18 16:52:04 +08:00
Arsh
8a5b0c1f3a
Switch build.inlineStylesheets default to auto (#8118) 
* switch inlineStylesheets default

* use previous default for astro/test

* use previous default for content-collections-render.test.js

* integrations: node, deno, mdx, markdown

* typedocs: switch inlineStylesheets default

* Update example to show non-default

* add changeset

* reword changeset

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-18 07:52:06 +01:00
Nate Moore
1f6497c334
fix(dev): open to base path (#8123) 2023-08-17 16:51:08 -05:00
Alexander Niebuhr
2540feedb0
feature(@astrojs/cloudflare): port functionPerRoute (#8078) 
* port functionPerRoute to cloudflare

* add changeset

* port bugfix to next

* update changeset

* Update packages/astro/src/core/build/generate.ts

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

* update changeset

* update README

* add TODO comment

* Update .changeset/wise-cameras-agree.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update .changeset/wise-cameras-agree.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update .changeset/nasty-garlics-listen.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* update README

* Update .changeset/wise-cameras-agree.md

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

* Update packages/integrations/cloudflare/README.md

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

---------

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
 2023-08-17 16:40:28 -05:00
Nate Moore
fa6b68a776
fix(#6965): fix build stats (#8122) 2023-08-17 15:34:36 -05:00
Martin Trapp
b290f0a997
only update our own history entires during back navigation through view transitions (#8116) 2023-08-17 12:18:30 -04:00
Matthew Phillips
ea7ff5177d
astro: namespace for middleware and components (#8101) 
* `astro:` namespace for middleware and components

* Update errors to use namespace

* Create a namespace module just for the astro: stuff
 2023-08-17 09:28:42 -04:00
Martin Trapp
da6e3da1ce
fix: reinsert attribute to specify direction of ViewTransition (forward / back) (#8109) 2023-08-17 09:28:21 -04:00
Matthew Phillips
cbb77af978 Merge branch 'main' into next 2023-08-17 08:54:28 -04:00
Erika
2484dc4080
config: remove ~/assets alias (#8113) 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Mia Kanashi <chad@redpilled.dev>
 2023-08-17 14:22:26 +02:00
Julien Barbay
d6b4943764
feat(assets): support remote images (#7778) 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Princesseuh <princssdev@gmail.com>
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
 2023-08-17 13:10:50 +02:00
Colin McDonnell
dff0f0f8dd
Detect Bun package manager in create-astro (#7944) 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-17 09:35:19 +01:00
Arsh
097a8e4e91
Prerendering corner cases (#8070) 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-17 09:34:31 +01:00
Nate Moore
5b4b782451
fix(solid): update babel-preset-solid (#8107) 2023-08-16 15:59:36 -05:00
Martin Trapp
0e0fa605d1
Fix 8083 (#8105) 
* override wrong positions in browser history

* Lost events are taken into account during throttling
 2023-08-16 16:38:18 -04:00
Nate Moore
e6e1de4f08
[create-astro] verify connectivity and --template (#8102) 
* feat(create-astro): verify that --template exists

* feat: verify internet connectivity

* chore: skip connectivity check on --dry-run

* chore: fix lint
 2023-08-16 14:37:43 -05:00
Matthew Phillips
16a3fdf931
Add experimentalReactChildren option to React integration (#8082) 
* wip: support true react vnodes in renderer

* Add new experimentalReactChildren option to React integration

* Update the test

* Add docs

* Update packages/integrations/react/server.js

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

* Update with a better test

* Update .changeset/yellow-snakes-jam.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update packages/integrations/react/README.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update packages/integrations/react/README.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-16 13:40:57 -04:00
Nate Moore
7177f7579b
Cleanup dotfiles in dist (#8092) 
* fix(#7933, plt-789): cleanup dotfiles during build

* chore: add changeset
 2023-08-16 09:20:38 -05:00
Erika
b76c166bdd
feat: unflag experimental.assets (#7921) 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
 2023-08-16 10:21:05 +02:00
Eric Mika
0bf2cca5d7
Filter out Svelte's unknown class prop console warnings (#7291) 
* Filter out Svelte's unexpected class prop console warnings

Astro's hydration code passes a `class` prop to Svelte components, inducing Svelte to log a warning about an unknown prop. Preempting this by exporting a `class` prop from the Svelte component isn't a viable workaround since `class` is a reserved identifier in JS.

This PR implements the console-filtering workaround suggested by @HiDeoo in #5665, borrowing the `useConsoleFilter` approach from the [preact integration](a1c0cbe604/packages/integrations/preact/src/server.ts (L72-L94)).

It would probably be better to generalize console filtering so it could be shared across multiple integrations.

Ideally there would be a way to handle this in Svelte, but as was pointed out in the issue thread even they resort to [similar cringe-inducing hackery](https://github.com/sveltejs/kit/blob/master/packages/kit/src/runtime/client/client.js#L1974-L1996) in sveltekit.

* Only filter Svelte console warnings in dev builds

* Add changeset

* Fix lint error.

---------

Co-authored-by: bluwy <bjornlu.dev@gmail.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-15 17:31:01 -05:00
Houston (Bot)
53ad9efde4
[ci] release (#8090) 
* [ci] release

* Update packages/create-astro/CHANGELOG.md

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-15 16:12:45 -05:00
Martin Trapp
56e7c5177b
Handle noscript tags in head during ViewTransitions (#8091) 2023-08-15 16:26:37 -04:00
Nate Moore
04755e8465
fix(create-astro): update install step (#8089) 2023-08-15 12:25:24 -05:00
Houston (Bot)
087270c61f
[ci] release (#8064) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-15 22:35:58 +08:00
Greg Cobb
a12027b6af
fix: Removed extra double quotes from computed style in shiki code component (#8035) 2023-08-15 22:29:16 +08:00
hbgl
560e459246
Stream request body instead of buffering it in memory (#8084) 
Co-authored-by: Matthew Phillips <matthew@matthewphillips.info>
 2023-08-15 15:26:18 +01:00
Emanuele Stoppa
7530d5689d Merge remote-tracking branch 'origin/main' into next 2023-08-15 09:24:06 +01:00
Bjorn Lu
68efd4a8b2
Export astro/compiler-runtime and cleanup exports (#8085) 2023-08-15 16:21:28 +08:00
Sergey Shishkin
c19987df0b
Export AstroConfigType properly as type and not as a Zod schema value (#7702) 2023-08-15 08:30:39 +01:00
Alexander Niebuhr
7b77b34cef
fix(@astrojs/cloudflare): unsynced astro asset support flag (#8079) 
* fix astro assets support in cloudflare

* add changeset
 2023-08-14 14:23:36 -05:00
Nate Moore
44cf30a252
chore: slim create-astro deps (#8077) 2023-08-14 14:23:14 -05:00
Robin Neal
da517d4055
fix: remove react identifierPrefix from client:only (#8075) 
This was causing React components rendered with client:only
to be prefixed with null. While not technically causing any
issues, it is unintended and could be considered a bug.

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-14 11:26:03 -05:00
Nate Moore
3e46634fd5
Support flags for astro add (#8032) 
* astro add cli pass down arguments to install cmd

* add changeset

* feat: pass common flags down to install command

* Update .changeset/soft-colts-heal.md

---------

Co-authored-by: Elod Tobak <tobakelod@gmail.com>
 2023-08-14 10:50:49 -05:00
Matthew Phillips
4477bb41c8
Update types to specify that compress defaults to true (#8072) 
* Update types to specify that compress defaults to true

* Update astro.ts

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-14 11:10:37 -04:00
Nate Moore
5208a3c8fe
fix: remove ./dist/jsx/* exports (#8030) 2023-08-14 09:22:01 -05:00
James Garbutt
d1f7143f9c
fix(astro): strongly type Astro.self (#7866) 
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Co-authored-by: Princesseuh <princssdev@gmail.com>
 2023-08-14 16:04:45 +02:00
Houston (Bot)
19f9edf977
[ci] release (beta) (#8067) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-14 08:46:22 -05:00
Erika
afc45af202
feat(assets): Add support for passing non-awaited imports to the Image component and getImage (#8066) 
* feat(assets): Add support for passing non-awaited imports to the Image component and `getImage`

* test: add test
 2023-08-14 15:29:42 +02:00
Bjorn Lu
2aa6d8ace3
Add changeset for internal helper package (#8062) 2023-08-14 08:22:44 -05:00
Martin Trapp
bee284cb77
docs: fix github search link in README.md (#8063) 
Co-authored-by: Elian ☕️ <hello@elian.codes>
 2023-08-14 11:22:13 +02:00
Houston (Bot)
f39a80c583
[ci] release (#8043) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-11 14:02:47 -04:00
Matthew Phillips
4a145c4c7d
Fix same-page transition with different query params (#8042) 2023-08-11 13:54:31 -04:00
Houston (Bot)
e1a886530f
[ci] release (#8023) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-11 11:22:23 -04:00
Houston (Bot)
40efae6550
[ci] release (beta) (#7952) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-11 11:14:20 -04:00
Emanuele Stoppa
866ed4098e
feat: expose user astro error (#8012) 2023-08-11 15:57:29 +01:00
Arsh
f974c95a27
Add Incremental Static Regeneration support for the Netlify's on-demand builders adapter (#7975) 
* feat(netlify): expose builders ttl as a local

* add changeset

* docs(netlify): caching using on-demand builders

* reword readme section

* Update packages/integrations/netlify/package.json

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>

* include builders-types.d.ts in the distribution

* document caveat regarding query params

* update changeset

* mutation -> function

* locals.netlify -> locals.runtime

* update types and changeset

* Apply suggestions from code review

Co-authored-by: Elian ☕️ <hello@elian.codes>

* Apply suggestions from code review

Co-authored-by: Elian ☕️ <hello@elian.codes>

---------

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Elian ☕️ <hello@elian.codes>
 2023-08-11 19:39:44 +05:30
Matthew Phillips
519a1c4e84
JSX refactor (#7924) 
* JSX refactor

* Get preact/compat test to pass

* Use include config

* Remove old astro flavored markdown test

* Move babel dep to preact

* Remove errant debugger

* Update lockfile

* Update the multi-framework example

* Update e2e tests

* Fix nested-in-vue tests

* Add back in astro check

* Update packages/astro/src/core/create-vite.ts

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

* Update packages/astro/src/core/create-vite.ts

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

* Update packages/integrations/solid/src/index.ts

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

* Update packages/integrations/solid/src/index.ts

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

* Update .changeset/perfect-horses-tell.md

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

* Move the comment about the include config

* Remove redundant alias config

* Use react's own preamble code

* Use the base for the preamble

* Remove solid redundancy

* Update .changeset/perfect-horses-tell.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update based on review comments

* Oops

---------

Co-authored-by: Fred K. Schott <fkschott@gmail.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-11 10:05:02 -04:00
Matthew Phillips
6b57628d12
Prevent Vercel NFT from scanning /dev (#8039) 
* Prevent Vercel NFT from scanning /dev

* Add a comment
 2023-08-11 09:58:32 -04:00
Matthew Phillips
405913cdf2
Prevent script re-execution on page evaluation (#8033) 2023-08-11 08:56:12 -04:00
Emanuele Stoppa
87d4b18437
fix: middleware entry point to not be set (#8036) 
* fix: middleware entry point to not be set

* chore: update tests
 2023-08-11 12:24:12 +01:00
Matthew Phillips
2ee418e06a
Remove the Nelify Edge adapter (#8029) 2023-08-10 14:38:51 -04:00
Jerry_wu
b16cb787fd
Support --host for Node adapter preview (#6928) 
* supporting a network address access a website when an user set host = true in Node environment

* fix bug

* sumbit test code

* optimism

* delect white space

* test

* fix test

* fix test error

* test

* test

* test

* fix test error

* Optimizing code based on the comments

* optimize test

* fix: rebase issues

* chore: format

* chore: add changeset

* chore: format

* chore: format

* chore: lint

---------

Co-authored-by: wuls <linsheng.wu@beantechs.com>
Co-authored-by: Nate Moore <nate@astro.build>
 2023-08-10 13:22:50 -05:00
Matthew Phillips
9cc4e48e6a
Remove the Vercel Edge adapter (#8015) 
* Remove the Vercel Edge adapter

* Update tests

* Update .changeset/plenty-keys-add.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Show enabling edge middleware

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-10 13:12:13 -04:00
Nate Moore
8292c41311
fix(#5637): fix yarn berry support for create-astro (#8028) 2023-08-10 12:33:37 -04:00
Nate Moore
1b8d302099
Ensure dev server restart respects base removal (#8027) 
* fix(#6067): dev server restart respects base removal

* chore: remove baseCss
 2023-08-10 10:52:21 -05:00
Alexander Niebuhr
ffcfcddb75
feat(@astrojs/cloudfalre): add cloudflare envs to Astro.locals (#7541) 
* add support for advanced mode

* add support for directory mode

* use asset fallback as in cloudflare's docs

* update locals

* come up with new runtime in `Astro.locals`

* add overwrite protection

* minor cleanup

* changeset

* address review comments

* move overwrite protection to adapter

* fix types

* fix comment

* resolve review comments

* update changeset

* add test

* redo ts

* fix integration test port

* updated tests, add new port

* add TODO comment

* update changeset

* add JSDoc

* Update packages/integrations/cloudflare/src/runtime.ts

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-10 10:19:00 -05:00
Bjorn Lu
34cb200216
Clear todos and remove css kebab handling (#8019) 2023-08-10 22:15:21 +08:00
Bjorn Lu
c23377caaf
Fix getCollection return new instance in prod (#8022) 2023-08-10 22:13:32 +08:00
Martin Trapp
86bee28121
View Transitions: do not animate same page navigation, but animate hash links to different pages (#8013) 
* Links with hash marks are now supported if they lead to a different page

* treat links to same page equally, independent of hash or not

* Links to the same page do not trigger view transitions

* special treatment for trailing hash

* view transitions: simpler rule to exclude in-page links
 2023-08-10 10:07:13 -04:00
Houston (Bot)
fc30b8539c
[ci] release (#8017) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-10 21:25:28 +08:00
Emanuele Stoppa
14b0626f3e Merge remote-tracking branch 'origin/main' into next 2023-08-10 11:49:52 +01:00
Bjorn Lu
5b1e39ef6e
Move hoisted script analysis optimization as experimental (#8011) 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-10 12:52:57 +08:00
Marco Schumacher
ea30a9d4f2
more efficient _routes.json for cloudflare integration (#7846) 
* more efficient _routes.json for cloudflare integration

* added tests

* updated pnpm-lock.yaml

* added changeset

* cleaned up test

* fix: convert window path separators

* updated docs

* handle more cases

* Apply suggestions from code review

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

* incorporate feedback from code review

* used other pnpm version

* better fallback for empty include array

* adjust test case to changed fallback for empty include array

* updated docs

---------

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
 2023-08-10 04:04:09 +01:00
Houston (Bot)
9cb32e2a5f
[ci] release (#8000) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-09 15:31:34 -05:00
dave caruso
58b121d42a
Support Bun by adjusting how @babel/plugin-transform-react-jsx is imported. (#8007) 
* Support bun/other tooling that respects `__esModule`

* Add changeset file
 2023-08-09 14:11:41 -05:00
Erika
08c3afb860
feat: remove @astrojs/image completely (#7922) 2023-08-09 15:03:59 -04:00
Emanuele Stoppa
670ef109db Merge remote-tracking branch 'origin/main' into next 2023-08-09 16:28:14 +01:00
Jany Belluz
79376f842d
Remove nested JSON.stringify from props serialization (#7995) 2023-08-09 13:06:21 +01:00
Bjorn Lu
65c354969e
Fix examples check hang (#7998) 2023-08-09 17:06:29 +08:00
Bjorn Lu
0f637c71e5
Preserve base slash when trailingSlash ignore (#7878) 2023-08-09 17:02:37 +08:00
Juan Martín Seery
16161afb2b
fix: EndpointOutput type with encoding 'binary' (#8003) 
* fix: `EndpointOutput` type with encoding `'binary'`

* Changeset
 2023-08-08 20:19:32 -03:00
Chris Swithinbank
315d58f27b
Add shorthand for Starlight templates to create astro (#7993) 
* Add shorthand for Starlight templates to `create astro`

* Update packages/create-astro/src/actions/template.ts

* Update packages/create-astro/src/actions/template.ts

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-08 12:08:46 -05:00
Emanuele Stoppa
7bd1b86f85
feat: new attribute scope style strategy (#7893) 2023-08-08 12:59:56 +01:00
Bjorn Lu
70f34f5a35 Remove StreamingCompatibleResponse polyfill (#7981) 2023-08-08 11:04:17 +01:00
Bjorn Lu
b675acb2aa Remove undici dep (#7980) 2023-08-08 11:04:17 +01:00
Bjorn Lu
3c31008519 Remove markdown component (#7931) 2023-08-08 11:04:17 +01:00
Houston (Bot)
2ac1c1e260 [ci] release (beta) (#7897) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-08 11:04:14 +01:00
Emanuele Stoppa
f32d093a28 feat: change compressHTML default value to true (#7918) 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-08 11:02:51 +01:00
Erika
7511a4980f feat: add noop service and make integrations that needs it use it (#7903) 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-08 11:02:51 +01:00
Erika
997a0db8a4 feat: use external @astrojs/check (#7892) 
* feat: use @astrojs/check

* fix: what happened in my rebase??

* nit: adjust with feedback
 2023-08-08 11:02:51 +01:00
Bjorn Lu
32669cd475 Refactor MDX components exports handling (#7904) 2023-08-08 11:02:51 +01:00
Erika
c0de7a7b0f feat: make Sharp the default image service (#7908) 
* feat: make Sharp the default image service

* chore: lockfile
 2023-08-08 11:02:51 +01:00
Emanuele Stoppa
f01eb585e7 feat: change default port to 4321 (#7874) 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
 2023-08-08 11:02:51 +01:00
Emanuele Stoppa
41390c2ebd ci: change release tag name (#7898) 2023-08-08 11:02:51 +01:00
Matthew Phillips
e1ae56e724 Make Astro.cookies.get(key) return undefined (#7888) 2023-08-08 11:02:00 +01:00
Emanuele Stoppa
c69c347980 chore: remove deleted package 2023-08-08 11:02:00 +01:00
Emanuele Stoppa
c335881dcc chore: enter pre release mode (#7883) 2023-08-08 11:02:00 +01:00
Bjorn Lu
84af8ed9d1 Move MDX plugin re-ordering hack to MDX integration (#7872) 2023-08-08 11:02:00 +01:00
Chris Swithinbank
e204270507 Tweak adapter config CHANGELOG (#7853) 2023-08-08 11:02:00 +01:00
Emanuele Stoppa
cd2d7e7698 feat: astro features (#7815) 2023-08-08 11:02:00 +01:00
Emanuele Stoppa
80f1494cda feat: adapter features, deprecate astro configs (#7839) 2023-08-08 11:02:00 +01:00
Emanuele Stoppa
036388f66d feat: pass logger to integrations (#7816) 2023-08-08 11:02:00 +01:00
Erika
364d861bd5 feat: remove automatic flattening of getStaticPaths result (#7845) 
* feat: remove automatic flattening of `getStaticPaths` result

* chore: changeset
 2023-08-08 11:01:59 +01:00
Erika
148e61d249 feat: remove webapi in favor of a smaller polyfill (#7840) 
* feat: remove webapi in favor of a smaller polyfill

* test: remove old test

* test: 🤦‍♀️

* chore: changeset
 2023-08-08 11:01:45 +01:00
Emanuele Stoppa
7d2f311d42 feat: remove support for old API routes syntax (#7822) 2023-08-08 11:01:33 +01:00
Erika
96beb883ad Update tsconfig.json presets for TS 5.0 (#7785) 2023-08-08 11:01:33 +01:00
Emanuele Stoppa
0f06255041 feat: upper case the name of the endpoints (#7783) 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
 2023-08-08 11:01:33 +01:00
Erika
d0679a666f Remove support for Node 16 (#7780) 2023-08-08 11:01:33 +01:00
Houston (Bot)
2e36d96588
[ci] release (#7988) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-07 16:21:15 -05:00
Nate Moore
8e5a27b488
fix: ensure injectRoute works during build (#7986) 2023-08-07 15:54:55 -05:00
Houston (Bot)
9509a66a7b
[ci] release (#7958) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-07 13:51:05 -05:00
Chris Swithinbank
ec06dd9bbb
Fix formatting in Lit README (#7985) 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-07 20:03:09 +02:00
André Alves
9d0070095e
Fix missing CSS when 404 server Response redirects to a custom 404 page (#7946) 
* Fix missing css import on 404 redirect

* Chore: changeset

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-07 12:51:50 -05:00
Nate Moore
c2682a17c0
Fix injectRoute (#7943) 
* fix: inject route! hack!

* refactor: use integration container to resolve all injected routes

* chore: add changeset

* Fix pnpm workspace injectRoute bug

See https://github.com/withastro/astro/issues/7561#issuecomment-1620063634

Closes #7561

* Revert "Fix pnpm workspace injectRoute bug"

This reverts commit 3082c7c269.

* Update .changeset/stupid-pants-press.md

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>

* Update packages/astro/src/vite-plugin-scripts/page-ssr.ts

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>

* refactor: cleanup injectedRoute resolution logic

---------

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
 2023-08-07 11:24:28 -05:00
Nate Moore
6cd7290d2c
Refactor page filename logic (#7983) 
* fix(#7561): refactor astro page filename logic

* chore: add changeset
 2023-08-07 10:57:03 -05:00
Bjorn Lu
a4a637c8f7
Fix inline root resolve logic (#7977) 2023-08-07 21:43:03 +08:00
Timon Jurschitsch
51028f85c6
Add URL to RSSOptions.site type (#7964) 2023-08-07 16:49:55 +08:00
Matthew Phillips
a00cfb8942
Fix race condition when performing swap for fallback (#7945) 
* Fix race condition when performing swap for fallback

* Adding a changeset

* Use let
 2023-08-04 08:48:11 -04:00
Houston (Bot)
8226002c0a
[ci] release (#7941) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-03 16:47:20 -05:00
Nate Moore
89cd4b877e
Handle error state for version (#7939) 
* fix(create-astro): handle error state for version

* fix: handle missing version
 2023-08-03 16:03:04 -05:00
Houston (Bot)
49b3cf423b
[ci] release (#7937) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-03 15:16:51 -04:00
Matthew Phillips
4b6deda360
Export createTransitionScope from the runtime (#7936) 2023-08-03 14:41:08 -04:00
Nate Moore
6035bb35f2
Fix duplicate slash handling (#7935) 
* fix(#7806): collapse duplicate slashes

* refactor: handle request.url with duplicate slashes

* chore: improve duplicate slash test

* fix: only collapse duplicate slashes once

* chore: appease TS
 2023-08-03 13:13:39 -05:00
Houston (Bot)
39b044e09b
[ci] release (#7912) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-03 10:54:48 -04:00
Bjorn Lu
1f0ee494a5
Fix failed server restart calling integration hooks twice (#7917) 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
 2023-08-03 22:26:24 +08:00
Matthew Phillips
41afb84057
Persistent DOM in ViewTransitions (#7861) 
* First pass at transition:persist

* Persistent islands

* Changeset

* Updated compiler

* Use official release

* Upgrade again

* Refactor to allow head content to persist untouched

* >=

* Specify the types for "astro:persist"

* Automatically persist links

* Use reference for array

* Upgrade to latest compiler version

* Explain the feature

* Update .changeset/empty-experts-unite.md

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

* Update .changeset/empty-experts-unite.md

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

* Update .changeset/empty-experts-unite.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update .changeset/empty-experts-unite.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-08-02 14:42:01 -04:00
Martin Trapp
c264be3497
Fix scroll position in view transition (#7882) (#7911) 2023-08-02 13:07:30 -04:00
Bjorn Lu
00cb28f496
Improve sourcemap generation and performance (#7901) 2023-08-02 11:30:53 +08:00
ottomated
c00b6f0c49
Fix astro/app import (#7821) 
* core -> core.js

* changeset

* test

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-01 18:34:22 -05:00
Hee
560d0dab1c
feat: add cache headers to assets in Vercel adapter (#7729) 
* feat: cache assets in Vercel adapter

* Update tidy-tips-doubt.md

* chore: update lockfile

* Update packages/integrations/vercel/test/static-assets.test.js

* Update packages/integrations/vercel/test/static-assets.test.js

* Update packages/integrations/vercel/test/static-assets.test.js

* chore: update split test

---------

Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com>
Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-01 18:06:50 -05:00
DixCouleur
4dd6c7900c
Fix "res.writeHead is not a function" in Express/node middleware (#7708) 
* fix: res.writeHead is not a function

* fix: handler params type added

* fix: handler function params error

* Update packages/integrations/node/src/nodeMiddleware.ts

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-01 17:10:29 -05:00
Tony Dang
e1e958a758
Fix: Content Collections - Ignore .json files nested in non-underscored subdirectories within underscored directories (#7909) 
* test: add test file so tests fail before fix

* fix: ignore files nested in underscore directories

* chore: add changeset

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-01 16:08:11 -05:00
Houston (Bot)
1d9e34b136
[ci] release (#7877) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-08-01 23:38:24 +08:00
Sam Hulick
5c5da8d2fb
feat: add logging for when hydrate's JSON parse fails (#7887) 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
 2023-08-01 16:33:38 +01:00
Nate Moore
298dbb89f2
Refactor 404 and 500 approach (#7754) 
* fix(app): refactor 404 and 500 approach

* chore: refactor logic

* fix: always treat error as page

* test: migrate ssr-prerender-404 to node adapter

* feat: merge original response metadata with error response

* chore: update lockfile

* chore: trigger ci

* chore(lint): fix lint issue

* fix: ensure merged request has proper status

* fix(node): prerender test

* chore: update test label

* fix(node): improve 404 behavior in middleware mode

* fix(vercel): improve 404 behavior

* fix(netlify): improve 404 behavior

* chore: update test labels

* chore: force ci

* chore: fix lint

* fix: avoid infinite loops

* test: fix failing test in Node 18

* chore: remove volta
 2023-08-01 09:52:16 -05:00
Bjorn Lu
0b8375fe82
Fix streaming Astro components (#7895) 2023-08-01 21:30:47 +08:00
Bjorn Lu
ebf7ebbf7a
Refactor and improve Astro config loading flow (#7879) 2023-08-01 17:11:26 +08:00
André Alves
9e22038472
Fix incorrect build path logging for 404.astro pages (#7885) 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
 2023-08-01 08:53:47 +01:00
Emanuele Stoppa
89d015db6c
fix: scan getStaticPaths only in .astro files (#7876) 2023-07-31 17:24:13 +01:00
Yan Thomas
1859960d04
Update old link from @astrojs/netlify README (#7862) 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
 2023-07-31 13:50:53 +01:00
Houston (Bot)
d2b6dabfb3
[ci] release (#7854) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-07-28 12:34:00 -04:00
Matthew Phillips
861f10eafd
Fix redirect in SSR (Node and dynamic) (#7856) 2023-07-28 12:00:26 -04:00
Houston (Bot)
98ca04f915
[ci] release (#7851) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-07-28 09:12:05 -04:00
Matthew Phillips
49a4b28202
Scroll position restoration (#7800) 
* Scroll position restoration

* Adding a changeset

* Throttle state persistence

* very important change
 2023-07-28 09:07:00 -04:00
Bjorn Lu
e50f646758
Fix head propagation for MDX components (#7838) 2023-07-28 18:00:53 +08:00
Emanuele Stoppa
2275c7d56b
fix: dev server should redirect when a page doesn't exist (#7841) 2023-07-28 09:20:00 +01:00
Houston (Bot)
3b422272e6
[ci] release (#7813) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-07-27 15:33:13 -04:00
Matthew Phillips
59b5562326
Allow the Image component to get transitions (#7836) 
* Images and view transitions

* Upgrade compiler

* Adding a changeset
 2023-07-27 15:08:45 -04:00
Matthew Phillips
7dbcbc86b3
Track added links/styles/scripts to prevent duplicates (#7843) 
* temporary change

* Track rendered styles and links to prevent duplicates

* Adding a changeset

* Fix names
 2023-07-27 14:42:22 -04:00
Matthew Phillips
5161cf919c
Add astro:beforeload event (#7823) 
* Add astro:beforeload event

* Adding a changeset

* Update .changeset/chilled-elephants-develop.md

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>

---------

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
 2023-07-27 08:57:37 -04:00
Matthew Phillips
267487e63e
Prevent navigation on hash change (#7824) 2023-07-27 08:42:04 -04:00
Erika
b063a2d8ae
fix(assets): Fix endpoint not being injected when an integration would enable experimental.assets (#7829) 2023-07-27 11:37:27 +02:00
Erika
d5f526b339
test: add test in the Node adapter for astro:assets (#7734) 2023-07-26 23:58:47 +02:00
Erika
31c4031ba7
fix: squoosh not working on Windows in certain situations (#7826) 2023-07-26 21:38:37 +02:00
Matthew Phillips
42a21b5da6
Prevent building .html files in hybrid mode (#7805) 
* Prevent building .html files in hybrid mode

* Adding a changeset
 2023-07-26 07:58:57 -04:00
Houston (Bot)
db8c04002f
[ci] release (#7784) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-07-25 15:15:41 -04:00
Bjorn Lu
0f677c009d
Refactor Astro rendering to write results directly (#7782) 2023-07-25 23:44:25 +08:00
Matthew Phillips
188eeddd47
Execute scripts on page navigation (view transitions) (#7786) 
* Execute scripts on page navigation (view transitions)

* Update .changeset/sharp-seas-smile.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
 2023-07-25 08:35:47 -04:00
Alex Sherwin
7461e82c81
Add "allowHTML" option for Markdoc with HTML parsing/processing (#7597) 
* 7576 - initial support for HTML inside Markdoc.

This uses htmlparser2 to perform a pure token transform/mutation
on the markdown-it tokens, replacing the original raw HTML string
tokens with a richer set of tokens per HTML node, and in the process
Markdoc tags are interleaved in the resulting token graph at the
appropriate locations

This removes the legacy config of the @astrojs/markdoc integration
entirely (suggested by @bholmesdev) and introduces a new type for
options to be specified in the astro config, initially, with just the new
"enableHTML" option

When "enableHTML" is *not* enabled (the default), the behavior
of the entire @astrojs/markdoc integration should remain functionally
equivalent to before this change

* 7576 - fixed issues with whitespace preservation

also:

* cleaned up " to ' for astro project preferred linting
* made the html rendering test fixture use a dynamic path

* 7576 - detailed nested HTML test coverage

* 7576 -  component + HTML interleaved tests

* 7576 -  fix lint problems from previous changes

* 7576 -  some commentary

* 7576 -  file naming, refactor html under imports, package.json exports definition for html

* 7576

* move out of extensions dir, remove export
* cdata handling changes

* 7576

* inline license from third party code
* cleanup test class copy of HTML output
* remove // third party indicators for imports (clarification: not third party code, just a indicator this group of imports is third party)

* 7576 - fixed test before/after for DRY'ness

* 7576 - no need to React-ify HTML attribute case

* 7576 - rename "enableHTML" option to "allowHTML"

* Added Markdoc allowHTML feature changeset

* 7576 - updated README with allowHTML info

* 7576 - fixed changeset typo

* 7576 - minor edits based on PR feedback for docs

* 7576 - minor edits based on PR feedback for docs
 2023-07-24 19:34:06 -04:00
Kevin Whinnery
0a1b33349f
Update esbuild target for Deno (#7687) 
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
 2023-07-24 22:58:05 +08:00
Houston (Bot)
e80896a67c
[ci] release (#7763) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-07-24 17:09:11 +08:00
Bjorn Lu
3567afac44
Fix rendering TextEncoder encoding error regression (#7777) 2023-07-24 16:22:05 +08:00
Birk Skyum
0c9959704f
Bump vite to 4.4.6 (#7746) 2023-07-24 16:21:17 +08:00
Erika
da7f1128bf
Fix missing referrerpolicy attribute on script tags (#7766) 
* fix(astro-jsx): Add missing `referrerpolicy` attribute for script tags

* chore: changeset
 2023-07-23 15:00:41 +02:00
Erika
1792737dae
Misc improvements for astro:assets (#7759) 2023-07-21 23:59:14 +02:00
Houston (Bot)
16a41528e4
[ci] release (#7737) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2023-07-21 16:37:17 -04:00
Matthew Phillips
274e675328
Prevent FOUC with production links in ViewTransitions (#7756) 
* Prevent FOUC with production links in ViewTransitions

* Adding changeset

* Move up so it works with fallback too
 2023-07-21 16:26:42 -04:00