Commit graph

5129 commits

Author SHA1 Message Date
Matthew Phillips
463a1c2147
Fix: Relative imports inside of hosited script on windows (#3423)
* Failing test

* Add some debugging

* Normalize filename to remove @fs prefix

* Adds a changeset

* Break it again

* Fix it

* Update assertion
2022-05-24 11:34:08 -04:00
FredKSchott
af179c0d89 [ci] collect stats 2022-05-24 12:02:33 +00:00
tony-sull
eb4382a251 [ci] format 2022-05-23 20:53:42 +00:00
Tony Sullivan
0209d6276c
Updates hydration scripts to use absolute paths (#3422)
* WIP: proof of concept fix to use absolute paths

* correct fix to handle absolute paths and config.base

* adding tests for hydration scripts with config.base

* chore: add changeset

* fix: ensure posix paths are used for Windows compat
2022-05-23 20:52:48 +00:00
Matthew Phillips
28ede84a88
Split up e2e HMR test (#3425) 2022-05-23 15:56:38 -04:00
github-actions[bot]
8eec97fdd1
[ci] release (#3409)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-05-23 13:26:07 -04:00
tony-sull
d0720ccfb4 [ci] format 2022-05-23 16:57:55 +00:00
Tony Sullivan
ff56f083bc
Adding E2E tests for client hydration and HMR (#3374)
* adding Tailwind E2E tests with Playwright

* package.json updates

* adding e2e tests to CI workflow

* using e2e for dev tests, mocha for build tests

* refactor: sharing test-utils helpers

* chore: update lockfile

* Adding contributing docs

* Revert "refactor: sharing test-utils helpers"

This reverts commit 48496f43bc99eab30747baf6e83041ba4932e786.

* refactor: simpler solution to resolving e2e test fixtures

* chore: updating lockfile

* refactor: cleaning up how URLs are resolved in e2e tests

* install playwright deps in CI

* ensure playwright deps are installed during CI

* adding a basic HMR test for tailwind styles

* using @e2e for playwright test packages

* adding react hydration and HMR tests

* adding hydration and HMR tests  for preact

* adding svelte hydration and HMR tests

* adding solid-js hydration and HMR tests

* adding solid hydration and HMR tests

* adding vue hydration and HMR tests

* adding client:media tests

* fixing Lit hydration and HMR tests

* fixing up the Vue e2e tests

* fixing up svelte tests

* chore: test cleanup

* chore: cleaning up test element IDs

* chore: updating lock file

* chore: update lockfile after merge

* TEMP: disabling React e2e tests

* Revert "TEMP: disabling React e2e tests"

This reverts commit ed1bad9cbc.

* updating to use the new editFiles helper

* chore: updating lock file

* updating lock file

* updating lockfile

* TEMP: watching for console logs

* TEMP: testing typescript tests

* updating test:e2e scripts for config file

* seems like it didn't find the config file?

* use a fresh dev server for each test

* removing Lit tests for now

* Revert "removing Lit tests for now"

This reverts commit 4970a8093e.

* updating test config for CI

* WIP: disabling HMR tests to track down why they're unreliable

* TEMP: logging to debug HMR test

* afterEach isn't a global in Playwright

* fix: the test's file reset helper was using a URL not filepath

* one last try, why is the HMR test hanging at cleanup?

* resetting files after tailwind HMR test

* create the onNextChange watcher before editFile is called

* moving the file changed sync into editFile()

* code refactor + Astro Component HMR test

* chore: lint fixes

* adding a test suite for the framework-multiple example app
2022-05-23 16:56:45 +00:00
Pranav Karawale
63c26c1b24
Fix GitHub Issue creation link (closes #3257) (#3421)
* Add IDs to bug report issue form
* Replace 'body' with correct input id for prefilling form
2022-05-23 11:02:03 -05:00
FredKSchott
c8174a079a [ci] collect stats 2022-05-23 12:02:31 +00:00
FredKSchott
3aa1f7a003 [ci] collect stats 2022-05-22 12:02:34 +00:00
FredKSchott
51e80d55d3 [ci] collect stats 2022-05-21 12:02:20 +00:00
bholmesdev
62e0efa043 [ci] format 2022-05-20 21:27:42 +00:00
Ben Holmes
4de53eccef
Fix: support FormData object on fetch body (#3417)
* refactor: make node-fetch external in rollup build

* deps: make node-fetch standard dep

* refactor: switch to node-fetch pkg ref in fetch.ts

* chore: changeset

* chore: bump webapi to minor change
2022-05-20 17:26:41 -04:00
tony-sull
d296eb63eb [ci] format 2022-05-20 20:08:13 +00:00
Tony Sullivan
d372d29ef8
Fix: Only trim /1 from the canonical URL for paginate() routes (#3393)
* only trim /1 from canonical URLs for paginate() routes

* chore: fixing eslint warning

* chore: add changeset

* typo: copy paste error

* adding a test validation error message

* verifying canonical for all three test routes

* TEMP: extra test logging to track down the failure

* TEMP: additional test logging to see what the failing CLI messages are

* TEMP: digging deeper, it's getting stuck on port 3000 is taken

* TEMP: why is it breaking when LOCAL isn't logged?

* TEMP: still digging, strange how consistent this failure is

* finally found it - the new test wasn't closing the dev server...
2022-05-20 20:07:30 +00:00
tony-sull
1f148dbcfd [ci] format 2022-05-20 19:59:55 +00:00
Tony Sullivan
6373508458
Enforcing routing priority during production builds (#3407)
* WIP: have a few test failures to track down

* WIP: still a few failures to fix

* WIP: fixes the issue of dynamic routes stepping on static routes

* Resolve route priority before building routes for `getStaticPaths()`

* chore: adding comments explaining why this filter is needed

* chore: adding changeset

* got too fancy with the test suite, these routes weren't valid

* simplifying the test cases

* TEMP: is this test breaking my CI run?

* Revert "TEMP: is this test breaking my CI run?"

This reverts commit 291af2a1b6f075ebfc74002886e43110731b3e1b.

* slots-preact didn't list @astrojs/preact as a dep

* reverting copy/paste error
2022-05-20 19:58:59 +00:00
Matthew Phillips
60d7164015
Upgrade the compiler (#3416) 2022-05-20 15:08:50 -04:00
bholmesdev
421eb3b5d4 [ci] format 2022-05-20 19:04:21 +00:00
Ben Holmes
fb5572bebd
Fix: components in imported markdown (#3398)
* test: add with-components to astro-markdown fixture

* fix: markdown pathname with /@fs prefix

* feat: add loadMetadata helper for md

* feat: fix components in Astro.glob results!

* fix: md import path

* Revert "feat: add loadMetadata helper for md"

This reverts commit 76cf96f4be3d0e19589f84025c0131352d0b6cc8.

* fix: add back $$loadMetadata helper

* feat: add second comp framework to md test

* chore: core/render/dev lint

* chore: changeset

* fix: short circuit if mod doesn't have metadata

* fix: skip mod graph preloading in dev

* refactor: make md metadata check recursive

* refactor: extract metadata helper to util

* fix: remove unecessary mod graph query

* fix: move md import flag to util for deno bundling issue

* fix: remove 'dev' mode from test utils build

* feat: add global hashset for seen metadata

* refactor: flip Promise.all to for await for perf!

* Revert bc I was wrong! "refactor: flip Promise.all to for await for perf!"

This reverts commit da8a6873f5.
2022-05-20 15:03:21 -04:00
Fred K. Schott
195f3f7eb7
[ci] update lockfile (#3414)
Co-authored-by: FredKSchott <FredKSchott@users.noreply.github.com>
2022-05-20 12:02:10 -05:00
FredKSchott
3b60169c75 [ci] collect stats 2022-05-20 12:02:23 +00:00
Nate Moore
b26d48d275
Defer head injection until renderPage (#3408)
* fix(#3195, #3197): only perform head injection for renderPage

* chore: add changeset
2022-05-19 15:21:48 -05:00
github-actions[bot]
4dfd341928
[ci] release (#3405)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-05-19 13:35:19 -04:00
Matthew Phillips
a35c89d2ac Fix react spectrum test lockfile issue 2022-05-19 13:27:08 -04:00
matthewp
435518845f [ci] format 2022-05-19 17:12:59 +00:00
Matthew Phillips
4007aebc6a
Provide a good error message when loading react spectrum (#3406)
* Provide a good error message when loading react spectrum

* Adds a changeset
2022-05-19 13:12:04 -04:00
natemoo-re
e9c137cf5f [ci] format 2022-05-19 15:50:10 +00:00
Nate Moore
d34859d750
Expose file and url for Astro files (#3385)
* feat: update test

* feat: return `file` and `url` for astro files

* chore: add changeset

* fix: use private names $$file and $$url

* test: update markdown test

* chore: update fileId logic to strip query params
2022-05-19 10:49:14 -05:00
Fred K. Schott
a7480452b1
[ci] update lockfile (#3404)
Co-authored-by: FredKSchott <FredKSchott@users.noreply.github.com>
2022-05-19 10:22:27 -05:00
matthewp
e118b8a91d [ci] format 2022-05-19 12:39:11 +00:00
Matthew Phillips
0c9f770e8a
Include server CSS in the manifest assets (#3402)
* Include server CSS in the manifest assets

* Adds a changeset
2022-05-19 08:38:27 -04:00
FredKSchott
f0aea84920 [ci] collect stats 2022-05-19 12:02:27 +00:00
github-actions[bot]
b330c5b72e
[ci] release (#3400)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-05-18 21:36:32 +00:00
tony-sull
f1d7d543b0 [ci] format 2022-05-18 20:10:07 +00:00
Tony Sullivan
0d3c673dd9
Fix: Support .html requests in dev (#3401)
* WIP: this regex should handle .html as well

* much simpler!  Just fix the req.url, don't touch the manifest

* only handle .html requests when config.build.format === 'file'

* chore: add changeset
2022-05-18 20:09:23 +00:00
matthewp
43cfd7e769 [ci] format 2022-05-18 19:12:28 +00:00
Matthew Phillips
2939be5f2d
Allow overriding build vite config options (#3392)
* Allow overriding build vite config options

* Adds a changeset

* Test svelte

* Move plugins down

* Assign after for the client too

* Spread output options on manually

* Remove .only
2022-05-18 15:11:40 -04:00
bholmesdev
54aba7231d [ci] format 2022-05-18 15:46:22 +00:00
Ben Holmes
1bf12260af
Fix: update "building for SSR" messaging on SSG (#3399)
* fix: update "building for SSR" messaging on SSG

* chore: changeset
2022-05-18 11:45:23 -04:00
Nate Moore
cf8015eaa2
fix: locale handling for logger (#3391)
* fix(#3309): use system default locale

* fix(#3309): use system default locale in create-astro

* test: add locale regression tests

* test: add i18n regression test
2022-05-18 10:45:09 -05:00
Matthew Phillips
6cec1b8ef2
Re-enable error recovery test (#3396)
* Re-enable error recovery test

* Doing some debugging

* Remove extra debugging

* longer wait

* make it wait even longer just to check

* Wait a very long time

* await the change, and then a little bit

* Give a longer timeout for the error recovery test

* OK, make it *very* long

* Run error tests separately

* Get rid of wait
2022-05-18 11:20:06 -04:00
Fred K. Schott
ef32b7c39c
[ci] update lockfile (#3395)
Co-authored-by: FredKSchott <FredKSchott@users.noreply.github.com>
2022-05-18 10:15:42 -05:00
Nate Moore
1297c10480
Fix tests: remove it.only (#3394)
* test: remove it.only

* test: skip failure until #3376 is revisited
2022-05-18 08:27:52 -04:00
FredKSchott
eea2d89c0d [ci] collect stats 2022-05-18 12:02:20 +00:00
Tony Sullivan
d8e5dfb977
Matching custom 404 pages using the manifest's route patterns (#3390)
* matching custom 404 pages using the manifest's route patterns

* windows: still need to use the relative paths for 404 matching
2022-05-17 21:27:06 +00:00
github-actions[bot]
f54072bd3f
[ci] release (#3378)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-05-17 11:50:18 -04:00
matthewp
42251f3eb4 [ci] format 2022-05-17 15:46:01 +00:00
Fred K. Schott
d102cab126
[ci] update lockfile (#3386)
Co-authored-by: FredKSchott <FredKSchott@users.noreply.github.com>
2022-05-17 11:44:50 -04:00