Compare commits

...

1 commit

Author SHA1 Message Date
Matthew Phillips
1a6400d6ab Revert "Add headless support to create-astro (#5898)"
This reverts commit d8919b1a21.
2023-01-24 11:48:02 -05:00
2 changed files with 65 additions and 87 deletions

View file

@ -43,8 +43,6 @@ May be provided in place of prompts
| `--template` | Specify the template name ([list][examples]) | | `--template` | Specify the template name ([list][examples]) |
| `--commit` | Specify a specific Git commit or branch to use from this repo (by default, `main` branch of this repo will be used) | | `--commit` | Specify a specific Git commit or branch to use from this repo (by default, `main` branch of this repo will be used) |
| `--fancy` | For Windows users, `--fancy` will enable full unicode support | | `--fancy` | For Windows users, `--fancy` will enable full unicode support |
| `--typescript` | Specify the [tsconfig][typescript] to use |
| `--yes`/`-y` | Skip prompts and use default values |
### Debugging ### Debugging
@ -62,4 +60,3 @@ yarn create astro my-astro-project --verbose
``` ```
[examples]: https://github.com/withastro/astro/tree/main/examples [examples]: https://github.com/withastro/astro/tree/main/examples
[typescript]: https://github.com/withastro/astro/tree/main/packages/astro/tsconfigs

View file

@ -30,7 +30,7 @@ import { TEMPLATES } from './templates.js';
// broke our arg parser, since `--` is a special kind of flag. Filtering for `--` here // broke our arg parser, since `--` is a special kind of flag. Filtering for `--` here
// fixes the issue so that create-astro now works on all npm version. // fixes the issue so that create-astro now works on all npm version.
const cleanArgv = process.argv.filter((arg) => arg !== '--'); const cleanArgv = process.argv.filter((arg) => arg !== '--');
const args = yargs(cleanArgv, { boolean: ['fancy', 'y'], alias: { y: 'yes' } }); const args = yargs(cleanArgv, { boolean: ['fancy'] });
// Always skip Houston on Windows (for now) // Always skip Houston on Windows (for now)
if (platform() === 'win32') args.skipHouston = true; if (platform() === 'win32') args.skipHouston = true;
prompts.override(args); prompts.override(args);
@ -226,10 +226,7 @@ export async function main() {
templateSpinner.text = green('Template copied!'); templateSpinner.text = green('Template copied!');
templateSpinner.succeed(); templateSpinner.succeed();
const install = args.y const installResponse = await prompts(
? true
: (
await prompts(
{ {
type: 'confirm', type: 'confirm',
name: 'install', name: 'install',
@ -248,12 +245,11 @@ export async function main() {
process.exit(1); process.exit(1);
}, },
} }
) );
).install;
if (args.dryRun) { if (args.dryRun) {
ora().info(dim(`--dry-run enabled, skipping.`)); ora().info(dim(`--dry-run enabled, skipping.`));
} else if (install) { } else if (installResponse.install) {
const installExec = execa(pkgManager, ['install'], { cwd }); const installExec = execa(pkgManager, ['install'], { cwd });
const installingPackagesMsg = `Installing packages${emojiWithFallback(' 📦', '...')}`; const installingPackagesMsg = `Installing packages${emojiWithFallback(' 📦', '...')}`;
const installSpinner = await loadWithRocketGradient(installingPackagesMsg); const installSpinner = await loadWithRocketGradient(installingPackagesMsg);
@ -272,16 +268,11 @@ export async function main() {
await info('No problem!', 'Remember to install dependencies after setup.'); await info('No problem!', 'Remember to install dependencies after setup.');
} }
const gitResponse = args.y const gitResponse = await prompts(
? true
: (
await prompts(
{ {
type: 'confirm', type: 'confirm',
name: 'git', name: 'git',
message: `Would you like to initialize a new git repository? ${reset( message: `Would you like to initialize a new git repository? ${reset(dim('(optional)'))}`,
dim('(optional)')
)}`,
initial: true, initial: true,
}, },
{ {
@ -292,12 +283,11 @@ export async function main() {
process.exit(1); process.exit(1);
}, },
} }
) );
).git;
if (args.dryRun) { if (args.dryRun) {
ora().info(dim(`--dry-run enabled, skipping.`)); ora().info(dim(`--dry-run enabled, skipping.`));
} else if (gitResponse) { } else if (gitResponse.git) {
await execaCommand('git init', { cwd }); await execaCommand('git init', { cwd });
ora().succeed('Git repository created!'); ora().succeed('Git repository created!');
} else { } else {
@ -307,15 +297,7 @@ export async function main() {
); );
} }
if (args.y && !args.typescript) { const tsResponse = await prompts(
ora().warn(dim('--typescript <choice> missing. Defaulting to "strict"'));
args.typescript = 'strict';
}
const tsResponse =
args.typescript ||
(
await prompts(
{ {
type: 'select', type: 'select',
name: 'typescript', name: 'typescript',
@ -337,23 +319,22 @@ export async function main() {
process.exit(1); process.exit(1);
}, },
} }
) );
).typescript;
if (tsResponse === 'unsure') { if (tsResponse.typescript === 'unsure') {
await typescriptByDefault(); await typescriptByDefault();
tsResponse.typescript = 'base'; tsResponse.typescript = 'base';
} }
if (args.dryRun) { if (args.dryRun) {
ora().info(dim(`--dry-run enabled, skipping.`)); ora().info(dim(`--dry-run enabled, skipping.`));
} else if (tsResponse) { } else if (tsResponse.typescript) {
const templateTSConfigPath = path.join(cwd, 'tsconfig.json'); const templateTSConfigPath = path.join(cwd, 'tsconfig.json');
fs.readFile(templateTSConfigPath, (err, data) => { fs.readFile(templateTSConfigPath, (err, data) => {
if (err && err.code === 'ENOENT') { if (err && err.code === 'ENOENT') {
// If the template doesn't have a tsconfig.json, let's add one instead // If the template doesn't have a tsconfig.json, let's add one instead
fs.writeFileSync( fs.writeFileSync(
templateTSConfigPath, templateTSConfigPath,
stringify({ extends: `astro/tsconfigs/${tsResponse}` }, null, 2) stringify({ extends: `astro/tsconfigs/${tsResponse.typescript}` }, null, 2)
); );
return; return;