cinny/CONTRIBUTING.md

48 lines
2.8 KiB
Markdown
Raw Normal View History

2021-07-28 13:15:52 +00:00
# Contributing to Cinny
First off, thanks for taking the time to contribute! ❤️
All types of contributions are encouraged and valued. Please make sure to read the relevant section before making your contribution. It will make it a lot easier for us maintainers and smooth out the experience for all involved. The community looks forward to your contributions. 🎉
2021-07-28 13:15:52 +00:00
> And if you like the project, but just don't have time to contribute, that's fine. There are other easy ways to support the project and show your appreciation, which we would also be very happy about:
2023-03-31 22:25:44 +00:00
>
2021-07-28 13:15:52 +00:00
> - Star the project
> - Tweet about it (tag @cinnyapp)
> - Refer this project in your project's readme
> - Mention the project at local meetups and tell your friends/colleagues
> - [Donate to us](https://cinny.in/#sponsor)
2021-07-28 13:15:52 +00:00
## Bug reports
2021-07-28 13:15:52 +00:00
Bug reports and feature suggestions must use descriptive and concise titles and be submitted to [GitHub Issues](https://github.com/ajbura/cinny/issues). Please use the search function to make sure that you are not submitting duplicates, and that a similar report or request has not already been resolved or rejected.
2021-07-28 13:15:52 +00:00
## Pull requests
2021-07-28 13:15:52 +00:00
> ### Legal Notice
2023-03-31 22:25:44 +00:00
>
2021-07-28 13:15:52 +00:00
> When contributing to this project, you must agree that you have authored 100% of the content, that you have the necessary rights to the content and that the content you contribute may be provided under the project license.
**NOTE: If you want to add new features, please discuss with maintainers before coding or opening a pull request.** This is to ensure that we are on same track and following our roadmap.
**Please use clean, concise titles for your pull requests.** We use commit squashing, so the final commit in the dev branch will carry the title of the pull request. For easier sorting in changelog, start your pull request titles using one of the verbs "Add", "Change", "Remove", or "Fix" (present tense).
2021-07-28 13:15:52 +00:00
Example:
2021-07-28 13:15:52 +00:00
2023-03-31 22:25:44 +00:00
| Not ideal | Better |
| ----------------------------------- | --------------------------------------------- |
| Fixed markAllAsRead in RoomTimeline | Fix read marker when paginating room timeline |
2021-07-28 13:15:52 +00:00
It is not always possible to phrase every change in such a manner, but it is desired.
2021-07-28 13:15:52 +00:00
**The smaller the set of changes in the pull request is, the quicker it can be reviewed and merged.** Splitting tasks into multiple smaller pull requests is often preferable.
2021-07-28 13:15:52 +00:00
Also, we use [ESLint](https://eslint.org/) for clean and stylistically consistent code syntax, so make sure your pull request follow it.
2021-07-28 13:15:52 +00:00
**For any query or design discussion, join our [Matrix room](https://matrix.to/#/#cinny:matrix.org).**
## Helpful links
2023-03-31 22:25:44 +00:00
- [BEM methodology](http://getbem.com/introduction/)
- [Atomic design](https://bradfrost.com/blog/post/atomic-web-design/)
- [Matrix JavaScript SDK documentation](https://matrix-org.github.io/matrix-js-sdk/index.html)