From 4fe4c8bb0360825e9df650e22e6d7da9a3ebd6c3 Mon Sep 17 00:00:00 2001 From: Krishan <33421343+kfiven@users.noreply.github.com> Date: Tue, 8 Nov 2022 20:21:51 +0530 Subject: [PATCH] Use Node Hydrogen LTS (#960) * Use node hydrogen lts in dockerfile * Use node v18.12.0 * Use node v18.12.0 * Use node v18.12.0 * use lts syntax * Update Nodejs LTS to v18.12.1 * Update Dockerfile * Update Dockerfile * Update readme --- .github/workflows/build-pull-request.yml | 4 ++-- .github/workflows/netlify-dev.yml | 2 +- .github/workflows/prod-deploy.yml | 2 +- Dockerfile | 2 +- README.md | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-pull-request.yml b/.github/workflows/build-pull-request.yml index b6379a53..5bbf2446 100644 --- a/.github/workflows/build-pull-request.yml +++ b/.github/workflows/build-pull-request.yml @@ -16,7 +16,7 @@ jobs: - name: Setup node uses: actions/setup-node@v3.5.1 with: - node-version: 17.9.0 + node-version: 18.12.1 cache: 'npm' - name: Install dependencies run: npm ci @@ -35,4 +35,4 @@ jobs: with: name: pr path: ./pr.txt - retention-days: 1 \ No newline at end of file + retention-days: 1 diff --git a/.github/workflows/netlify-dev.yml b/.github/workflows/netlify-dev.yml index 9a4ac6e0..edb79d86 100644 --- a/.github/workflows/netlify-dev.yml +++ b/.github/workflows/netlify-dev.yml @@ -15,7 +15,7 @@ jobs: - name: Setup node uses: actions/setup-node@v3.5.1 with: - node-version: 17.9.0 + node-version: 18.12.1 cache: 'npm' - name: Install dependencies run: npm ci diff --git a/.github/workflows/prod-deploy.yml b/.github/workflows/prod-deploy.yml index ed981c3c..686b812a 100644 --- a/.github/workflows/prod-deploy.yml +++ b/.github/workflows/prod-deploy.yml @@ -14,7 +14,7 @@ jobs: - name: Setup node uses: actions/setup-node@v3.5.1 with: - node-version: 17.9.0 + node-version: 18.12.1 cache: 'npm' - name: Install dependencies run: npm ci diff --git a/Dockerfile b/Dockerfile index 7ad952b1..dd3a7efa 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ ## Builder -FROM node:17.9.0-alpine3.15 as builder +FROM node:18.12.0-alpine3.15 as builder WORKDIR /src diff --git a/README.md b/README.md index d6675bd1..acf76629 100644 --- a/README.md +++ b/README.md @@ -84,7 +84,7 @@ UeGsouhyuITLwEhScounZDqop+Dx ## Local development > We recommend using a version manager as versions change very quickly. You will likely need to switch -between multiple Node.js versions based on the needs of different projects you're working on. [NVM on windows](https://github.com/coreybutler/nvm-windows#installation--upgrades) on Windows and [nvm](https://github.com/nvm-sh/nvm) on Linux/macOS are pretty good choices. Also recommended nodejs version is 16.15.0 LTS. +between multiple Node.js versions based on the needs of different projects you're working on. [NVM on windows](https://github.com/coreybutler/nvm-windows#installation--upgrades) on Windows and [nvm](https://github.com/nvm-sh/nvm) on Linux/macOS are pretty good choices. Also recommended nodejs version Hydrogen LTS (v18). Execute the following commands to start a development server: ```sh