michael/cinny
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity

settings-sticky-tabs #1

Merged
michael merged 2 commits from settings-sticky-tabs into dev 2023-03-31 22:16:53 +00:00
Conversation 0 Commits 2 Files changed 2 +23 -5
michael commented 2023-03-31 22:16:20 +00:00
Owner
Copy link
  • Add sticky positioning for tabs on the Settings panel
  • Also add sticky position for SpaceSettings

Description

The RoomSettings dialog uses sticky positioning for the tabs. I noticed that the
other Settings and SpaceSettings dialogs don't also have this. This is just a
small patch that uses the same settings on the other side.

It maybe be a good future extension to have this be an option on the tabs
themselves, or to make a wrapper component that implements the sticky. Let me
know if that's more preferable than this patch.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
- Add sticky positioning for tabs on the Settings panel - Also add sticky position for SpaceSettings <!-- Please read https://github.com/ajbura/cinny/blob/dev/CONTRIBUTING.md before submitting your pull request --> ### Description <!-- Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change. --> The RoomSettings dialog uses sticky positioning for the tabs. I noticed that the other Settings and SpaceSettings dialogs don't also have this. This is just a small patch that uses the same settings on the other side. It maybe be a good future extension to have this be an option on the tabs themselves, or to make a wrapper component that implements the sticky. Let me know if that's more preferable than this patch. Fixes # #### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings
michael added 2 commits 2023-03-31 22:16:20 +00:00
michael merged commit c673ee5928 into dev 2023-03-31 22:16:53 +00:00
michael referenced this pull request from a commit 2023-03-31 22:16:53 +00:00
settings-sticky-tabs (#1)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: michael/cinny#1
No description provided.
Delete branch "settings-sticky-tabs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?