From ce10d5ca082fff787c911bcadf8ec937be99033e Mon Sep 17 00:00:00 2001 From: Soonho Kong Date: Tue, 26 May 2015 15:24:09 -0400 Subject: [PATCH] fix(emacs/lean-flycheck.el): use flycheck-increment-error-columns instead of advice Comment from @lunaryorn (flycheck author): "Please don't use an advice to increment error columns. Flycheck has :error-filters and there is even a built-in one exactly for your use case: :error-filter flycheck-increment-error-columsn. Generally never use advises at all in libraries or modes. They are for user configuration, or as a very last resort only." --- src/emacs/lean-flycheck.el | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/emacs/lean-flycheck.el b/src/emacs/lean-flycheck.el index 2de9c78ce..1634959e1 100644 --- a/src/emacs/lean-flycheck.el +++ b/src/emacs/lean-flycheck.el @@ -45,6 +45,10 @@ (minimal-match (message (one-or-more (zero-or-more not-newline) (? "\r") "\n"))) "FLYCHECK_END" (? "\r") line-end)) + :error-filter + '(lambda (errors) + (flycheck-sanitize-errors (flycheck-increment-error-columns errors))) + :modes '(lean-mode)) (add-to-list 'flycheck-checkers 'lean-checker)) (defun lean-flycheck-turn-on () @@ -69,15 +73,6 @@ (lean-flycheck-turn-off) (lean-flycheck-turn-on))) -(eval-after-load "flycheck" - '(defadvice flycheck-try-parse-error-with-pattern - (after lean-flycheck-try-parse-error-with-pattern activate) - "Add 1 to error-column." - (let* ((err ad-return-value) - (col (and err (flycheck-error-column err)))) - (when (and (string= major-mode "lean-mode") col) - (setf (flycheck-error-column ad-return-value) (1+ col)))))) - (defun lean-flycheck-delete-temporaries () "Delete temporaries files generated by flycheck." (when (eq major-mode 'lean-mode) @@ -92,7 +87,6 @@ (tempfiles (--map (concat tempfile it) exts))) (mapc #'flycheck-safe-delete tempfiles)))) - (defun lean-flycheck-error-list-buffer-width () "Return the width of flycheck-error list buffer" (interactive)